ILLink: Don't mark attributes from MarkEntireType #108552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They are already marked from MarkType, called by MarkEntireType. The removed marking logic was using the assembly as the warning message origin, making these warnings hard to suppress (in addition to being redundant with the warnings at the type level).
dotnet-issue-labeler
bot
added
the
area-Tools-ILLink
sbomer
changed the title
dotnet-policy-service
bot
added
the
linkable-framework
|
Tagging subscribers to this area: @agocke, @sbomer, @vitek-karas |
This was referenced Oct 4, 2024
|
@dotnet/illink PTAL |
jtschuster
approved these changes
Oct 14, 2024
|
/ba-g "Job was abandoned due to timeout" |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They are already marked from MarkType, called by MarkEntireType. The removed marking logic was using the assembly as the warning message origin, making these warnings hard to suppress (in addition to being redundant with the warnings at the type level).
Fixes some warnings encountered in #108464 in the OOB library trimming step.