Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cdac] Begin adding MethodDesc APIs to the RuntimeTypeSystem contract #104811

Merged
merged 25 commits into from
Jul 20, 2024
Merged

[cdac] Begin adding MethodDesc APIs to the RuntimeTypeSystem contract #104811

merged 25 commits into from
Jul 20, 2024

Commits on Jul 18, 2024

  1. start GetMethodDescDataImpl

    @lambdageek
    lambdageek committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    ffc4b8a View commit details
    Browse the repository at this point in the history

  2. WIP: managed GetMethodDescData skeleton

    @lambdageek
    lambdageek committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    9e0272a View commit details
    Browse the repository at this point in the history

  3. wip: MethodDesc

    @lambdageek
    lambdageek committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    29e404c View commit details
    Browse the repository at this point in the history

  4. add MethodDescChunk

    @lambdageek
    lambdageek committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    9719c75 View commit details
    Browse the repository at this point in the history

  5. WIP: validating a MethodDesc

    @lambdageek
    lambdageek committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    f076f19 View commit details
    Browse the repository at this point in the history

  6. checkpoint: MethodDesc validation

    @lambdageek
    lambdageek committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    c935626 View commit details
    Browse the repository at this point in the history

  7. update contract

    @lambdageek
    lambdageek committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    fa42ef0 View commit details
    Browse the repository at this point in the history

  8. fix RuntimeTypeSystem unit tests 

    mock the additional data and globals
    @lambdageek
    lambdageek committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    27f4a96 View commit details
    Browse the repository at this point in the history

  9. update contract

    @lambdageek
    lambdageek committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    9dbd432 View commit details
    Browse the repository at this point in the history

  10. fix GetMethodDescChunkPointerMayThrow

    @lambdageek
    lambdageek committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    793681f View commit details
    Browse the repository at this point in the history

  11. fixup rebase

    @lambdageek
    lambdageek committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    a46f91e View commit details
    Browse the repository at this point in the history

  12. add data descriptor description to the contract

    @lambdageek
    lambdageek committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    3f82a89 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2024

  1. Apply suggestions from code review 

    Co-authored-by: Elinor Fung <[email protected]>
    @lambdageek @elinor-fung
    lambdageek and elinor-fung authored Jul 19, 2024
    Configuration menu
    Copy the full SHA
    8111d53 View commit details
    Browse the repository at this point in the history

  2. MayThrow -> Throwing

    @lambdageek
    lambdageek committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    07c810e View commit details
    Browse the repository at this point in the history

  3. Slot is ushort not byte

    @lambdageek
    lambdageek committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    6f1d9a8 View commit details
    Browse the repository at this point in the history

  4. remove unused property

    @lambdageek
    lambdageek committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    fa42684 View commit details
    Browse the repository at this point in the history

  5. add TargetPointer 32-/64-bit max constants

    @lambdageek
    lambdageek committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    9613999 View commit details
    Browse the repository at this point in the history

  6. use NewArrayHolder

    @lambdageek
    lambdageek committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    214ffe9 View commit details
    Browse the repository at this point in the history

  7. spelling

    @lambdageek
    lambdageek committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    c6e057a View commit details
    Browse the repository at this point in the history

  8. add globals to RTS contract

    @lambdageek
    lambdageek committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    b000f7a View commit details
    Browse the repository at this point in the history

  9. Merge remote-tracking branch 'origin/main' into cdac-methoddesc

    @lambdageek
    lambdageek committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    dc1812c View commit details
    Browse the repository at this point in the history

  10. remove unused usings

    @lambdageek
    lambdageek committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    d4f6299 View commit details
    Browse the repository at this point in the history

  11. constexpr cdac_offsets, not const

    @lambdageek
    lambdageek authored Jul 19, 2024
    Configuration menu
    Copy the full SHA
    10f0943 View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2024

  1. Apply suggestions from code review 

    Co-authored-by: Elinor Fung <[email protected]>
    @lambdageek @elinor-fung
    lambdageek and elinor-fung authored Jul 20, 2024
    Configuration menu
    Copy the full SHA
    515a3e3 View commit details
    Browse the repository at this point in the history

  2. make GetNumVtableSlots private

    @lambdageek
    lambdageek committed Jul 20, 2024
    Configuration menu
    Copy the full SHA
    1f182f1 View commit details
    Browse the repository at this point in the history