Fix ISOSDACInterface::GetThreadData reading the GC alloc context. #104762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The RuntimeThreadLocals struct that the gc_alloc_context is in wasn't being added to dump in Thread::EnumMemoryRegions.
dotnet-issue-labeler
bot
added
the
needs-area-label
jkoritzinsky
approved these changes
Jul 11, 2024
hoyosjs
approved these changes
Jul 11, 2024
mikem8361
added
area-Diagnostics-coreclr
and removed
needs-area-label
|
Tagging subscribers to this area: @tommcdon |
This was referenced Jul 12, 2024
Open
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RuntimeThreadLocals struct that the gc_alloc_context is in wasn't being added to dump in Thread::EnumMemoryRegions.
It is failing to read memory here in the DAC GetThreadData() before this change.