-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Arm64/Sve: Remove unwanted insScalableOpts and instructions #103620
Merged
Merged
Changes from 8 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
60925bc
Fix AV in GatherVector
kunalspathak b766817
Remove INS_SCALABLE_OPTS_UNPREDICATED
kunalspathak 04797f1
Remove INS_SCALABLE_OPTS_UNPREDICATED_WIDE
kunalspathak 4b949be
TO_PREDICATE AND TO_VECTOR
kunalspathak f3ebe4d
Remove INS_SCALABLE_OPTS_BROADCAST
kunalspathak 6c0cae0
Remove ins_sve_ldr_mask and ins_sve_str_mask
kunalspathak a395a9d
bug fix
kunalspathak 08efeae
jit format
kunalspathak a1861d2
proper handling of OperIsMemoryLoad() for Gather APIs
kunalspathak 3a30048
review comments
kunalspathak File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code is odd. This is because for predicates we always use INS_OPTS_SCALABLE_B for a mov, so the passed in
opt
value doesn't matter ?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, so basically, this code operates just on
INS_OPTS_SCALABLE_B
(and we added single test for that). For other places, if we have to passINS_OPTS_SCALABLE_B
if register types are predicate feels like an overhead, so instead this code expects it to be NONE, in which case it will set the options toINS_OPTS_SCALABLE_B
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would something like this work?
I think that shape makes it clearer the if-statement is debug-only code, and ensures
opt
is alwaysINS_OPTS_SCALABLE_B
even if we don't have asserts on to catch improper handling.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?