Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some more #ifdef BACKGROUND_GC to enable compilation for Wasm #102750

Merged
merged 1 commit into from
May 29, 2024

Conversation

yowl
Copy link
Contributor

@yowl yowl commented May 28, 2024

This PR #ifdefs out a few more functions and headers that don't compile when BACKGROUND_GC is false. From downstream dotnet/runtimelab#2591

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label May 28, 2024
Copy link
Contributor

Tagging subscribers to this area: @dotnet/gc
See info in area-owners.md if you want to be subscribed.

@yowl yowl marked this pull request as ready for review May 28, 2024 16:00
@yowl
Copy link
Contributor Author

yowl commented May 28, 2024

Marking as for review, some things timed out, but I'm assuming they are not related to these changes.

cc @SingleAccretion

@cshung cshung merged commit 5fbe5c4 into dotnet:main May 29, 2024
89 checks passed
Ruihan-Yin pushed a commit to Ruihan-Yin/runtime that referenced this pull request May 30, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jun 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-GC-coreclr community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants