Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Perf] Windows/x64: 8 Regressions on 3/11/2024 8:28:14 PM #99966

Closed
performanceautofiler bot opened this issue Mar 19, 2024 · 3 comments
Closed

[Perf] Windows/x64: 8 Regressions on 3/11/2024 8:28:14 PM #99966

performanceautofiler bot opened this issue Mar 19, 2024 · 3 comments
Assignees
Labels
arch-x64 area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI os-windows Priority:2 Work that is important, but not critical for the release runtime-coreclr specific to the CoreCLR runtime tenet-performance Performance related issue tenet-performance-benchmarks Issue from performance benchmark
Milestone

Comments

@performanceautofiler
Copy link

performanceautofiler bot commented Mar 19, 2024

Run Information

Name Value
Architecture x64
OS Windows 10.0.22621
Queue OwlWindows
Baseline 5161ccd6662f656a1a7dd394264e61a9955536bf
Compare 27214a0787f9a0ee95c799639431d9d16c25d1ac
Diff Diff
Configs CompilationMode:tiered, RunKind:micro

Regressions in System.Memory.Span<Int32>

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio
33.87 ns 52.74 ns 1.56 0.15 False
27.82 ns 51.83 ns 1.86 0.17 False
9.35 ns 12.35 ns 1.32 0.06 False

graph
graph
graph
Test Report

Repro

General Docs link: https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.Memory.Span&lt;Int32&gt;*'

Payloads

Baseline
Compare

System.Memory.Span<Int32>.IndexOfAnyFiveValues(Size: 33)

ETL Files

Histogram

JIT Disasms

System.Memory.Span<Int32>.IndexOfAnyFourValues(Size: 33)

ETL Files

Histogram

JIT Disasms

System.Memory.Span<Int32>.IndexOfAnyTwoValues(Size: 33)

ETL Files

Histogram

JIT Disasms

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

@performanceautofiler performanceautofiler bot added arch-x64 os-windows runtime-coreclr specific to the CoreCLR runtime untriaged New issue has not been triaged by the area owner labels Mar 19, 2024
@DrewScoggins DrewScoggins transferred this issue from dotnet/perf-autofiling-issues Mar 19, 2024
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Mar 19, 2024
@DrewScoggins DrewScoggins added tenet-performance Performance related issue tenet-performance-benchmarks Issue from performance benchmark labels Mar 19, 2024
@DrewScoggins
Copy link
Member

DrewScoggins commented Mar 19, 2024

@jeffschwMSFT jeffschwMSFT added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Mar 20, 2024
@vcsjones vcsjones removed the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Mar 20, 2024
@JulieLeeMSFT JulieLeeMSFT added this to the 9.0.0 milestone Mar 22, 2024
@JulieLeeMSFT JulieLeeMSFT removed the untriaged New issue has not been triaged by the area owner label Mar 29, 2024
@AndyAyersMS
Copy link
Member

For System.Memory.Span<Int32>.IndexOfAnyFiveValues(Size: 33) -- looks like all platforms were impacted, and things haven't recovered since.

image

@AndyAyersMS AndyAyersMS added the Priority:2 Work that is important, but not critical for the release label May 8, 2024
@AndyAyersMS
Copy link
Member

Looking again, things seem to have improved...

image

@github-actions github-actions bot locked and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-x64 area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI os-windows Priority:2 Work that is important, but not critical for the release runtime-coreclr specific to the CoreCLR runtime tenet-performance Performance related issue tenet-performance-benchmarks Issue from performance benchmark
Projects
None yet
Development

No branches or pull requests

5 participants