Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Perf] Windows/x64: 2 Regressions on 3/16/2024 1:13:28 AM #99965

Closed
performanceautofiler bot opened this issue Mar 19, 2024 · 1 comment · Fixed by #100169
Closed

[Perf] Windows/x64: 2 Regressions on 3/16/2024 1:13:28 AM #99965

performanceautofiler bot opened this issue Mar 19, 2024 · 1 comment · Fixed by #100169
Assignees
Labels
arch-x64 area-ExceptionHandling-coreclr os-windows runtime-coreclr specific to the CoreCLR runtime tenet-performance Performance related issue tenet-performance-benchmarks Issue from performance benchmark

Comments

@performanceautofiler
Copy link

Run Information

Name Value
Architecture x64
OS Windows 10.0.18362
Queue TigerWindows
Baseline f36aa7ec736735a3e92046c73d6e03029017b9fa
Compare 6f10cd3b1c7384057f8c35909fe093cbc4106ff2
Diff Diff
Configs CompilationMode:tiered, RunKind:micro

Regressions in Exceptions.Handling

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio
170.23 μs 200.51 μs 1.18 0.20 False

graph
Test Report

Repro

General Docs link: https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'Exceptions.Handling*'

Payloads

Baseline
Compare

Exceptions.Handling.CatchAndThrowOtherDeep(kind: Software)

ETL Files

Histogram

JIT Disasms

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository


Run Information

Name Value
Architecture x64
OS Windows 10.0.18362
Queue TigerWindows
Baseline f36aa7ec736735a3e92046c73d6e03029017b9fa
Compare 6f10cd3b1c7384057f8c35909fe093cbc4106ff2
Diff Diff
Configs CompilationMode:tiered, RunKind:micro

Regressions in System.Collections.Tests.Perf_BitArray

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio
18.73 ns 20.97 ns 1.12 0.14 False

graph
Test Report

Repro

General Docs link: https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.Collections.Tests.Perf_BitArray*'

Payloads

Baseline
Compare

System.Collections.Tests.Perf_BitArray.BitArrayBitArrayCtor(Size: 512)

ETL Files

Histogram

JIT Disasms

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

@performanceautofiler performanceautofiler bot added arch-x64 os-windows runtime-coreclr specific to the CoreCLR runtime untriaged New issue has not been triaged by the area owner labels Mar 19, 2024
@DrewScoggins DrewScoggins removed the untriaged New issue has not been triaged by the area owner label Mar 19, 2024
@DrewScoggins DrewScoggins transferred this issue from dotnet/perf-autofiling-issues Mar 19, 2024
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Mar 19, 2024
@DrewScoggins DrewScoggins added tenet-performance Performance related issue tenet-performance-benchmarks Issue from performance benchmark and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Mar 19, 2024
@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label Mar 19, 2024
@DrewScoggins
Copy link
Member

DrewScoggins commented Mar 19, 2024

Related to #99624. Will also link improvements here as well.

Windows Amd Regressions: dotnet/perf-autofiling-issues#31424
Windows x64 Regressions: dotnet/perf-autofiling-issues#31924
Linux x64 Regressions: dotnet/perf-autofiling-issues#31341
Windows ARM64 Regressions: dotnet/perf-autofiling-issues#31619, dotnet/perf-autofiling-issues#31614, dotnet/perf-autofiling-issues#31614 (Ampere)
Linux ARM64 Regressions: dotnet/perf-autofiling-issues#31605

@dotnet-policy-service dotnet-policy-service bot removed the untriaged New issue has not been triaged by the area owner label Mar 28, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Apr 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-x64 area-ExceptionHandling-coreclr os-windows runtime-coreclr specific to the CoreCLR runtime tenet-performance Performance related issue tenet-performance-benchmarks Issue from performance benchmark
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants