Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reenable sdk->runtime subscription for ApiCompat task #95022

Closed
akoeplinger opened this issue Nov 20, 2023 · 3 comments
Closed

Reenable sdk->runtime subscription for ApiCompat task #95022

akoeplinger opened this issue Nov 20, 2023 · 3 comments

Comments

@akoeplinger
Copy link
Member

akoeplinger commented Nov 20, 2023

In #94292 the ApiCompat version bump ran into an issue with source build.
We temporarily reverted the bump and disabled the subscription 736b3d22-d45c-4c36-de26-08db63374d9b.

This issue tracks reenabling that.

/cc @ViktorHofer

@akoeplinger akoeplinger added this to the 9.0.0 milestone Nov 20, 2023
@ghost
Copy link

ghost commented Nov 20, 2023

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

In #94292 the ApiCompat version bump ran into an issue with source build.
We temporarily reverted the bump and disabled the subscription 736b3d22-d45c-4c36-de26-08db63374d9b.

This issue tracks reenabling that.

Author: akoeplinger
Assignees: -
Labels:

area-Infrastructure

Milestone: 9.0.0

@ViktorHofer
Copy link
Member

Ongoing discussion from #94292 (comment):

That sounds like a design mismatch. Source built msbuild task packages target net9.0 when building from source which can't be executed in our portable source build leg. Shouldn't this source build leg always target a nightly SDK to avoid such a major version mismatch?

It does. In theory it's not limited to source build, right? A dependent package could have been changed from targeting net8.0 to producing net9.0 exclusively and that would cause the same issue in the other non-source-build legs. Such a scenario probably would never occur I assume.
/cc @MichaelSimons

We try to avoid that in a non source build environment by making people use properties like NetToolMinimum and NetToolCurrent. Not saying that this issue hasn't happened before but probably only rarely. The solution to that is usually just to revert the TFM upgrade in a specific component until repositories consume a newer SDK.
We can't really do that in source build as it requires us to target the latest version of .NETCoreApp, even for build tasks.

cc @MichaelSimons for opinions on this

@ViktorHofer
Copy link
Member

Re-enabled.

@github-actions github-actions bot locked and limited conversation to collaborators Feb 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants