Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement real fix for C5271 in IJW test build #92879

Closed
vitek-karas opened this issue Oct 2, 2023 · 2 comments · Fixed by #106153
Closed

Implement real fix for C5271 in IJW test build #92879

vitek-karas opened this issue Oct 2, 2023 · 2 comments · Fixed by #106153
Labels
area-Host in-pr There is an active PR which will close this issue when it is merged
Milestone

Comments

@vitek-karas
Copy link
Member

Recent VS upgrade introduces C5271, and causes a build break like this:

src\native\corehost\test\ijw\ijw.cpp(6): warning C5271: consider replacing #using <System.Console.dll>  with command line argument /FU "F:\dotnet\runtime2\.dotnet\packs\Microsoft.NETCore.App.Ref\8.0.0-rc.1.23414.4\ref\net8.0\System.Console.dll"
src\native\corehost\test\ijw\ijw.cpp(7): warning C5271: consider replacing #using <System.Runtime.Loader.dll>  with command line argument /FU "F:\dotnet\runtime2\.dotnet\packs\Microsoft.NETCore.App.Ref\8.0.0-rc.1.23414.4\ref\net8.0\System.Runtime.Loader.dll"

#92878 disables the warning. This issue is to track implementing a real fix for this and removing the warning disable.

@ghost ghost added the untriaged New issue has not been triaged by the area owner label Oct 2, 2023
@ghost
Copy link

ghost commented Oct 2, 2023

Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov
See info in area-owners.md if you want to be subscribed.

Issue Details

Recent VS upgrade introduces C5271, and causes a build break like this:

src\native\corehost\test\ijw\ijw.cpp(6): warning C5271: consider replacing #using <System.Console.dll>  with command line argument /FU "F:\dotnet\runtime2\.dotnet\packs\Microsoft.NETCore.App.Ref\8.0.0-rc.1.23414.4\ref\net8.0\System.Console.dll"
src\native\corehost\test\ijw\ijw.cpp(7): warning C5271: consider replacing #using <System.Runtime.Loader.dll>  with command line argument /FU "F:\dotnet\runtime2\.dotnet\packs\Microsoft.NETCore.App.Ref\8.0.0-rc.1.23414.4\ref\net8.0\System.Runtime.Loader.dll"

#92878 disables the warning. This issue is to track implementing a real fix for this and removing the warning disable.

Author: vitek-karas
Assignees: -
Labels:

area-Host

Milestone: -

@GrabYourPitchforks
Copy link
Member

FYI this issue causing build failures in the release/* branches because #92878 exists only in main.

@agocke agocke added this to AppModel Nov 28, 2023
@elinor-fung elinor-fung added this to the 9.0.0 milestone Feb 2, 2024
@elinor-fung elinor-fung removed the untriaged New issue has not been triaged by the area owner label Feb 2, 2024
@dotnet-policy-service dotnet-policy-service bot added the in-pr There is an active PR which will close this issue when it is merged label Aug 8, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Sep 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Host in-pr There is an active PR which will close this issue when it is merged
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants