Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[browser][MT] legacy JS interop needs GC boundaries on main thread too #90044

Closed
pavelsavara opened this issue Aug 4, 2023 · 5 comments · Fixed by #96841
Closed

[browser][MT] legacy JS interop needs GC boundaries on main thread too #90044

pavelsavara opened this issue Aug 4, 2023 · 5 comments · Fixed by #96841
Assignees
@kg @pavelsavara @lambdageek
Labels
arch-wasm WebAssembly architecture area-VM-threading-mono os-browser Browser variant of arch-wasm
Milestone
9.0.0

Comments

@pavelsavara
Copy link
Member

Calling legacy mono_wasm_invoke_method_ref on the main thread could lead to GC transition assert at mono-threads-state-machine.c:807

See #89909 (comment)
@pavelsavara pavelsavara added arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm labels Aug 4, 2023
@pavelsavara pavelsavara added this to the 8.0.0 milestone Aug 4, 2023
@ghost
Copy link

ghost commented Aug 4, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Calling legacy mono_wasm_invoke_method_ref on the main thread could lead to GC transition assert at mono-threads-state-machine.c:807

See #89909 (comment)

Author: pavelsavara
Assignees: kg, pavelsavara, lambdageek
Labels:

arch-wasm, area-System.Runtime.InteropServices.JavaScript, os-browser
Milestone: 8.0.0

@kg
Copy link
Member

kg commented Aug 4, 2023

Is this still 8.0 if the related issue is 9.0?

@pavelsavara
Copy link
Member Author

I think this is bug, not a new feature.

@lewing
Copy link
Member

lewing commented Aug 13, 2023

closing as a duplicate of #89909

@lewing lewing closed this as completed Aug 13, 2023
@pavelsavara pavelsavara reopened this Aug 21, 2023
@pavelsavara
Copy link
Member Author

This is not duplicate, it's different issue.

@pavelsavara pavelsavara modified the milestones: 8.0.0, 9.0.0 Aug 21, 2023
@pavelsavara pavelsavara mentioned this issue Nov 9, 2023
Closed
31 tasks
@pavelsavara pavelsavara mentioned this issue Jan 14, 2024
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Jan 14, 2024
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Jan 19, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Feb 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kg kg

@pavelsavara pavelsavara

@lambdageek lambdageek

Labels
arch-wasm WebAssembly architecture area-VM-threading-mono os-browser Browser variant of arch-wasm
Projects
None yet
Milestone
9.0.0
Development

Successfully merging a pull request may close this issue.

[browser] remove legacy js interop pavelsavara/runtime
4 participants
@lewing @kg @pavelsavara @lambdageek