Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JIT-EE interface cleanup #89845

Open
2 of 5 tasks
jakobbotsch opened this issue Aug 2, 2023 · 4 comments
Open
2 of 5 tasks

JIT-EE interface cleanup #89845

jakobbotsch opened this issue Aug 2, 2023 · 4 comments
Assignees
@jakobbotsch
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Milestone
10.0.0

Comments

@jakobbotsch
Copy link
Member

jakobbotsch commented Aug 2, 2023 •
edited by EgorBo
Loading

Just a tracking issue for a few things we can clean up at some point:

  • getNewHelper uses only the token's class handle on the EE side
  • CILJit::compileMethod is always passed CORJIT_FLAG_CALL_GETJITFLAGS, so flags can be removed
  • GetProfilingHandle never has indirected == true anymore
  • mapMethodDeclToMethodImpl is unused (done in Remove unused GETFIELD/SETFIELD helpers #105023)
  • CORINFO_HELP_LOOP_CLONE_CHOICE_ADDR is unused
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Aug 2, 2023
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Aug 2, 2023
@ghost
Copy link

ghost commented Aug 2, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Just a tracking issue for a few things we can clean up at some point:

  • getNewHelper uses only the token's class handle on the EE side
  • CILJit::compileMethod is always passed CORJIT_FLAG_CALL_GETJITFLAGS, so flags can be removed
Author: jakobbotsch
Assignees: -
Labels:

area-CodeGen-coreclr
Milestone: -

@jakobbotsch jakobbotsch added this to the 9.0.0 milestone Aug 2, 2023
@ghost ghost removed the untriaged New issue has not been triaged by the area owner label Aug 2, 2023
@SingleAccretion
Copy link
Contributor

mapMethodDeclToMethodImpl is dead code.

@EgorBo
Copy link
Member

EgorBo commented Jul 19, 2024

Added CORINFO_HELP_LOOP_CLONE_CHOICE_ADDR

@jakobbotsch
Copy link
Member Author

This cleanup is not needed for 9.0.

@jakobbotsch jakobbotsch modified the milestones: 9.0.0, 10.0.0 Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jakobbotsch jakobbotsch

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
10.0.0
Development

No branches or pull requests
3 participants
@EgorBo @jakobbotsch @SingleAccretion