Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust Networking metrics to follow OpenTelemetry semantic conventions #89093

Closed
antonfirsov opened this issue Jul 18, 2023 · 1 comment · Fixed by #89959, #89813 or #89809
Closed

Adjust Networking metrics to follow OpenTelemetry semantic conventions #89093

antonfirsov opened this issue Jul 18, 2023 · 1 comment · Fixed by #89959, #89813 or #89809
Assignees
Labels
area-System.Net enhancement Product code improvement that does NOT require public API changes/additions
Milestone

Comments

@antonfirsov
Copy link
Member

antonfirsov commented Jul 18, 2023

Edit: for folks landing on this issue, I'm linking the final spec of the Metrics implemented in .NET 8.0: https://github.com/lmolkova/semantic-conventions/blob/dotnet8-metrics/docs/dotnet/README.md


We are implementing the following metrics for .NET 8 with ad-hoc naming:

// Request metrics:
http-client-current-requests (scheme, host, port, method)
http-client-request-duration (scheme, host, port, method, status-code, protocol)
http-client-failed-requests  (scheme, host, port, method, status-code, protocol)

// Connection metrics:
http-client-current-connections      (protocol, scheme, host, port)
http-client-current-idle-connections (protocol, scheme, host, port)
http-client-connection-duration      (protocol, scheme, host, port)

// How long is a request waiting in the connection pool's queue:
http-client-requests-queue-duration  (protocol, scheme, host, port)

dns-lookups-requested(hostname)

We need to adjust these instruments to follow OpenTelemetry semantic conventions in naming and other aspects. Details TBD.

@antonfirsov antonfirsov added this to the 8.0.0 milestone Jul 18, 2023
@antonfirsov antonfirsov self-assigned this Jul 18, 2023
@ghost
Copy link

ghost commented Jul 18, 2023

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

We have implemented the following metrics for .NET 8 with ad-hoc naming:

// Request metrics:
http-client-current-requests (scheme, host, port, method)
http-client-request-duration (scheme, host, port, method, status-code, protocol)
http-client-failed-requests  (scheme, host, port, method, status-code, protocol)

// Connection metrics:
http-client-current-connections      (protocol, scheme, host, port)
http-client-current-idle-connections (protocol, scheme, host, port)
http-client-connection-duration      (protocol, scheme, host, port)

// How long is a request waiting in the connection pool's queue:
http-client-requests-queue-duration  (protocol, scheme, host, port, ?method?)

dns-lookups-requested(hostname)

We need to adjust these instruments to follow OpenTelemetry semantic conventions. Details TBD.

Author: antonfirsov
Assignees: antonfirsov
Labels:

area-System.Net

Milestone: 8.0.0

This was referenced Aug 1, 2023
@karelz karelz added in-pr There is an active PR which will close this issue when it is merged enhancement Product code improvement that does NOT require public API changes/additions labels Aug 3, 2023
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Aug 3, 2023
This was linked to pull requests Aug 4, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Sep 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Net enhancement Product code improvement that does NOT require public API changes/additions
Projects
None yet
2 participants