Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Design] .NET metrics naming standard #88515

Closed
JamesNK opened this issue Jul 7, 2023 · 6 comments · Fixed by #89813 or #89809
Closed

[Design] .NET metrics naming standard #88515

JamesNK opened this issue Jul 7, 2023 · 6 comments · Fixed by #89813 or #89809
Assignees
Labels
area-System.Diagnostics.Metric enhancement Product code improvement that does NOT require public API changes/additions
Milestone

Comments

@JamesNK
Copy link
Member

JamesNK commented Jul 7, 2023

What should instruments and tags be named?

Options:

  1. Follow event counters naming standard
  2. Follow OTel semantic conventions naming standard

Needs to be decided before .NET 8 ships.

@ghost ghost added the untriaged New issue has not been triaged by the area owner label Jul 7, 2023
@gfoidl
Copy link
Member

gfoidl commented Jul 7, 2023

Follow OTel semantic conventions naming standard

👍🏻

When there's a standard, that's used across platforms, this one should be followed.
E.g. in a micro-service scenario environment where heterogenous technologies are used, it would be great to have one standard for metrics (OTel) which allows for easier creation and interpretion of dashboards, etc.

@tommcdon tommcdon added this to the 8.0.0 milestone Jul 9, 2023
@ghost ghost removed the untriaged New issue has not been triaged by the area owner label Jul 9, 2023
@hoyosjs hoyosjs added the enhancement Product code improvement that does NOT require public API changes/additions label Jul 10, 2023
@noahfalk
Copy link
Member

We are on a path that the new names would be based around OpenTelemetry semantic conventions and trying to nail down the details of what the names would be. Lots of discussion is happening right now over in lmolkova/semantic-conventions#1. Feedback is welcome! (but the cutoff to get anything into RC1 is coming up quick)

@antonfirsov
Copy link
Member

antonfirsov commented Aug 3, 2023

@tarekgh given that all the key points affecting 8.0 dotnet/runtime metrics have been decided in the discussions under lmolkova/semantic-conventions#1 and the metrics renaming PRs have been merged, I think this can be closed.

@antonfirsov antonfirsov assigned noahfalk and unassigned noahfalk and antonfirsov Aug 3, 2023
@tarekgh
Copy link
Member

tarekgh commented Aug 3, 2023

@noahfalk @JamesNK is there anything pending here?

@JamesNK
Copy link
Member Author

JamesNK commented Aug 3, 2023

This is done in dotnet/runtime. The counters in aspnetcore still have open PRs with renaming.

@tarekgh
Copy link
Member

tarekgh commented Aug 4, 2023

Ok, closing this one then. Will be good if you can link the PRs to this issue.

@tarekgh tarekgh closed this as completed Aug 4, 2023
This was linked to pull requests Aug 4, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Sep 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Diagnostics.Metric enhancement Product code improvement that does NOT require public API changes/additions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants