Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dbgshim.dll!RegisterForRuntimeStartup can incorrectly fail with E_ACCESSDENIED on Windows #8717

Closed
gregg-miskelly opened this issue Aug 9, 2017 · 5 comments

Comments

@gregg-miskelly
Copy link
Contributor

RegisterForRuntimeStartup is requesting TOKEN_READ access when it should request TOKEN_QUERY access.

Here is the line of code with the bug: https://github.com/dotnet/coreclr/blob/32f0f9721afb584b4a14d69135bea7ddc129f755/src/utilcode/securityutil.cpp#L339

This prevents RegisterForRuntimeStartup from working correctly with Azure Service Fabric local simulator processes.

@lt72
Copy link
Contributor

lt72 commented Aug 9, 2017

Are the local simulator processes an internal testing or a production scenario?

@gregg-miskelly
Copy link
Contributor Author

That depends on your definition of 'production' -- this is how customers develop Azure Service Fabric applications on their dev box's. The problem might also exist with in-the-cloud debugging, but I am not sure if such a feature exists for Service Fabric.

@mikem8361 mikem8361 self-assigned this Aug 9, 2017
mikem8361 referenced this issue in mikem8361/coreclr Aug 9, 2017
Changed the open process token from TOKEN_READ to TOKEN_QUERY.
mikem8361 referenced this issue in dotnet/coreclr Aug 9, 2017
Changed the open process token from TOKEN_READ to TOKEN_QUERY.
mikem8361 referenced this issue in mikem8361/coreclr Aug 22, 2017
Changed the open process token from TOKEN_READ to TOKEN_QUERY.
@karelz
Copy link
Member

karelz commented Aug 28, 2017

BTW: I recommend to keep servicing issues opened, until they are merged into 2.0 servicing branch.

@karelz karelz reopened this Aug 28, 2017
@Petermarcu
Copy link
Member

This is approved for checkin when the branch is open for 2.0.2.

weshaggard referenced this issue in dotnet/coreclr Sep 1, 2017
Fixed issue #13282: dbgshim fails with E_ACCESSDENIED on Windows.
@Petermarcu
Copy link
Member

This was merged for 2.0.1. Closing now.

@msftgits msftgits transferred this issue from dotnet/coreclr Jan 31, 2020
@msftgits msftgits added this to the 2.0.x milestone Jan 31, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants