Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for successfully matching current RID when reading an empty RID graph #86250

Closed
elinor-fung opened this issue May 15, 2023 · 1 comment · Fixed by #91040
Closed

Add test for successfully matching current RID when reading an empty RID graph #86250

elinor-fung opened this issue May 15, 2023 · 1 comment · Fixed by #91040
Milestone

Comments

@elinor-fung
Copy link
Member

elinor-fung commented May 15, 2023

If there's an asset for the current RID as determined by the host (so on windows it would be win10-x64) and there's no RID graph but it's instructed to read the RID graph, the asset should still resolve.
Currently the test never exercises this case, since the CurrentRid will be the current build target RID (so on windows it would be win-x64), which is currently always portable RID, and thus never the one the host determines on its own.

It might be that on source-built runtime, where the build target is non-portable, it could happen that the host determined RID and the build target RID matches, in which case the test would fail.

Originally posted by @vitek-karas in #84100 (comment)

@ghost ghost added the untriaged New issue has not been triaged by the area owner label May 15, 2023
@ghost
Copy link

ghost commented May 15, 2023

Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov
See info in area-owners.md if you want to be subscribed.

Issue Details
          Maybe not for this change, but this test misses an interesting case.

If there's an asset for the current RID as determined by the host (so on windows it would be win10-x64) and there's no RID graph but it's instructed to read the RID graph, the asset should still resolve.
Currently the test never exercises this case, since the CurrentRid will be the current build target RID (so on windows it would be win-x64), which is currently always portable RID, and thus never the one the host determines on its own.

It might be that on source-built runtime, where the build target is non-portable, it could happen that the host determined RID and the build target RID matches, in which case the test would fail.

Originally posted by @vitek-karas in #84100 (comment)

Author: elinor-fung
Assignees: -
Labels:

area-Host

Milestone: -

@agocke agocke added this to AppModel Jul 10, 2023
@elinor-fung elinor-fung added this to the 8.0.0 milestone Aug 7, 2023
@elinor-fung elinor-fung removed the untriaged New issue has not been triaged by the area owner label Aug 7, 2023
@elinor-fung elinor-fung modified the milestones: 8.0.0, 9.0.0 Aug 17, 2023
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Aug 24, 2023
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Aug 24, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant