Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression on INTEL machines with TechEmpower Fortunes #86113

Closed
sebastienros opened this issue May 11, 2023 · 7 comments
Closed

Regression on INTEL machines with TechEmpower Fortunes #86113

sebastienros opened this issue May 11, 2023 · 7 comments
Assignees
@EgorBo
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI tenet-performance Performance related issue
Milestone
8.0.0

Comments

@sebastienros
Copy link
Member

image

Only INTEL, both windows and linux. All Fortunes middleware (not platform).

Minimum set of commits: a442971...ab98c9b
@sebastienros sebastienros added the tenet-performance Performance related issue label May 11, 2023
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label May 11, 2023
@ghost ghost added the untriaged New issue has not been triaged by the area owner label May 11, 2023
@sebastienros
Copy link
Member Author

/cc @EgorBo

@sebastienros sebastienros mentioned this issue May 11, 2023
Merged
@MihaZupan
Copy link
Member

From #84184 (comment)

Tried the following commits:

  1. 1b56e96 (PR Improve IndexOfAnyValues throughput for needles with 0 #84184)
  2. e241509 (commit just before nr. 3)
  3. 58a1365 (PR Unroll StringBuilder.Append for const string #85894)
load 1 2 3
Requests/sec 304,458 302,716 -0.57% 281,044 -7.69%
Requests 4,585,264 4,570,922 -0.31% 4,243,602 -7.45%
Bad responses 0 0 0

@sebastienros sebastienros mentioned this issue May 11, 2023
Merged
@sebastienros
Copy link
Member Author

Thanks @MihaZupan, that's very helpful.

@sebastienros
Copy link
Member Author

@EgorBo confirmed this would also be fixed by #85551

@MihaZupan
Copy link
Member

Since I already had the runtime built, here are the numbers from aspnet-perf-win to further confirm #85894 (comment):

load 2-perf 3-perf
Requests/sec 208,299 204,782 -1.69%
Requests 3,145,265 3,092,240 -1.69%
Bad responses 0 0

@jeffschwMSFT jeffschwMSFT added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label May 15, 2023
@ghost
Copy link

ghost commented May 15, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

image

Only INTEL, both windows and linux. All Fortunes middleware (not platform).

Minimum set of commits: a442971...ab98c9b

Author: sebastienros
Assignees: -
Labels:

tenet-performance, area-CodeGen-coreclr, untriaged, needs-area-label
Milestone: -

@JulieLeeMSFT JulieLeeMSFT added this to the 8.0.0 milestone May 16, 2023
@ghost ghost removed the untriaged New issue has not been triaged by the area owner label May 16, 2023
@JulieLeeMSFT JulieLeeMSFT removed the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label May 16, 2023
@EgorBo
Copy link
Member

EgorBo commented Jun 9, 2023

Fixed via #85551 + improved by Dynamic PGO:

image

@EgorBo EgorBo closed this as completed Jun 9, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Jul 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@EgorBo EgorBo

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI tenet-performance Performance related issue
Projects
None yet
Milestone
8.0.0
Development

No branches or pull requests
5 participants
@EgorBo @sebastienros @jeffschwMSFT @MihaZupan @JulieLeeMSFT