Regressions in System.Buffers.Binary.Tests.BinaryReadAndWriteTests #85988

performanceautofiler · 2023-05-09T11:27:00Z

Run Information

Name	Value
Architecture	x64
OS	Windows 10.0.18362
Queue	TigerWindows
Baseline	442141d696ee7d4ae54420974559e99738d753e6
Compare	c8f43d52f699c1da289a5cb36d371aec15901ab8
Diff	Diff
Configs	CompilationMode:tiered, RunKind:micro

Regressions in System.Buffers.Binary.Tests.BinaryReadAndWriteTests

Benchmark	Baseline	Test	Test/Base	Test Quality	Edge Detector	Baseline IR	Compare IR	IR Ratio	Baseline ETL	Compare ETL
MeasureReverseUsingNtoH - Duration of single invocation	605.61 ns	946.10 ns	1.56	0.01	True	6022.827101520892	8089.7074446351235	1.3431744442061604)	Trace	Trace
MeasureReverseEndianness - Duration of single invocation	614.26 ns	941.83 ns	1.53	0.00	True	6056.527359489527	8075.261900385958	1.333315515818388)	Trace	Trace

Test Report

Repro

General Docs link: https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md

Payloads

Baseline
Compare

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.Buffers.Binary.Tests.BinaryReadAndWriteTests*'

Payloads

Baseline
Compare

Histogram

System.Buffers.Binary.Tests.BinaryReadAndWriteTests.MeasureReverseUsingNtoH

Description of detection logic

IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 946.1020211179717 > 643.259435520526.
IsChangePoint: Marked as a change because one of 5/3/2023 7:05:50 AM, 5/9/2023 7:24:34 AM falls between 4/30/2023 6:17:41 PM and 5/9/2023 7:24:34 AM.
IsRegressionStdDev: Marked as regression because -145.33095665139552 (T) = (0 -943.5256872067196) / Math.Sqrt((100.76093042903165 / (21)) + (1.9921542971535473 / (13))) is less than -2.03693334345674 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (21) + (13) - 2, .025) and -0.5214730941818898 = (620.1395810512588 - 943.5256872067196) / 620.1395810512588 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked as regression because Edge Detector said so.

JIT Disasms

Baseline
Compare
Diff

System.Buffers.Binary.Tests.BinaryReadAndWriteTests.MeasureReverseEndianness

Description of detection logic

IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 941.8282251056002 > 645.1990668248882.
IsChangePoint: Marked as a change because one of 5/3/2023 7:05:50 AM, 5/9/2023 7:24:34 AM falls between 4/30/2023 6:17:41 PM and 5/9/2023 7:24:34 AM.
IsRegressionStdDev: Marked as regression because -172.69616839909932 (T) = (0 -942.899495537063) / Math.Sqrt((71.28264791595957 / (21)) + (0.9109916109751146 / (13))) is less than -2.03693334345674 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (21) + (13) - 2, .025) and -0.5172382205961809 = (621.4577794952738 - 942.899495537063) / 621.4577794952738 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked as regression because Edge Detector said so.

JIT Disasms

Baseline
Compare
Diff

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

The text was updated successfully, but these errors were encountered:

ghost · 2023-05-09T16:37:28Z

Tagging subscribers to this area: @dotnet/area-system-buffers
See info in area-owners.md if you want to be subscribed.

Issue Details

Run Information

Name	Value
Architecture	x64
OS	Windows 10.0.18362
Queue	TigerWindows
Baseline	442141d696ee7d4ae54420974559e99738d753e6
Compare	c8f43d52f699c1da289a5cb36d371aec15901ab8
Diff	Diff
Configs	CompilationMode:tiered, RunKind:micro

Regressions in System.Buffers.Binary.Tests.BinaryReadAndWriteTests

Benchmark	Baseline	Test	Test/Base	Test Quality	Edge Detector	Baseline IR	Compare IR	IR Ratio	Baseline ETL	Compare ETL
MeasureReverseUsingNtoH - Duration of single invocation	605.61 ns	946.10 ns	1.56	0.01	True	6022.827101520892	8089.7074446351235	1.3431744442061604)	Trace	Trace
MeasureReverseEndianness - Duration of single invocation	614.26 ns	941.83 ns	1.53	0.00	True	6056.527359489527	8075.261900385958	1.333315515818388)	Trace	Trace

Test Report

Repro

General Docs link: https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md

Payloads

Baseline
Compare

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.Buffers.Binary.Tests.BinaryReadAndWriteTests*'

Payloads

Baseline
Compare

Histogram

System.Buffers.Binary.Tests.BinaryReadAndWriteTests.MeasureReverseUsingNtoH

Description of detection logic

IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 946.1020211179717 > 643.259435520526.
IsChangePoint: Marked as a change because one of 5/3/2023 7:05:50 AM, 5/9/2023 7:24:34 AM falls between 4/30/2023 6:17:41 PM and 5/9/2023 7:24:34 AM.
IsRegressionStdDev: Marked as regression because -145.33095665139552 (T) = (0 -943.5256872067196) / Math.Sqrt((100.76093042903165 / (21)) + (1.9921542971535473 / (13))) is less than -2.03693334345674 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (21) + (13) - 2, .025) and -0.5214730941818898 = (620.1395810512588 - 943.5256872067196) / 620.1395810512588 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked as regression because Edge Detector said so.

JIT Disasms

Baseline
Compare
Diff

System.Buffers.Binary.Tests.BinaryReadAndWriteTests.MeasureReverseEndianness

Description of detection logic

IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 941.8282251056002 > 645.1990668248882.
IsChangePoint: Marked as a change because one of 5/3/2023 7:05:50 AM, 5/9/2023 7:24:34 AM falls between 4/30/2023 6:17:41 PM and 5/9/2023 7:24:34 AM.
IsRegressionStdDev: Marked as regression because -172.69616839909932 (T) = (0 -942.899495537063) / Math.Sqrt((71.28264791595957 / (21)) + (0.9109916109751146 / (13))) is less than -2.03693334345674 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (21) + (13) - 2, .025) and -0.5172382205961809 = (621.4577794952738 - 942.899495537063) / 621.4577794952738 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked as regression because Edge Detector said so.

JIT Disasms

Baseline
Compare
Diff

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

Author:	performanceautofiler[bot]
Assignees:	AndyAyersMS
Labels:	`area-System.Buffers`, `os-windows`, `arch-x64`, `runtime-coreclr`
Milestone:	-

cincuranet · 2023-05-09T16:38:02Z

Commit range is 7afd85d...edd6d63. Probably #85654, @jakobbotsch? Link to the benchmark.

Similar stuff in #85994.

jakobbotsch · 2023-05-09T16:48:14Z

Seems unlikely, #85654 had no diffs related to those benchmarks. But I don't see how the other commits would affect those benchmarks either.

AndyAyersMS · 2023-05-09T18:27:43Z

Also could be #85559 -- perhaps, some empty arrays got moved and so perturbed the alignment of the benchmark array?

tannergooding · 2023-07-24T23:39:59Z

This one is worth investigating more. It remains almost 1.5x slower with no clear culprit.

jakobbotsch · 2023-07-25T08:16:18Z

I'll take a closer look.

jakobbotsch · 2023-07-25T09:08:44Z

Yes this is from #85559, cc @EgorBo.

We end up putting a static array field used in the micro benchmark on the non-GC heap, but then we constant propagate its address into a loop and regress performance of the loop.

I wonder if we can generally avoid propagating from low weight blocks to high weight blocks, although it's probably not that simple. It also doesn't seem feasible to fix this in 8.0, so I will move this to 9.0.

-Importing BB01 (PC=000) of 'System.Buffers.Binary.Tests.BinaryReadAndWriteTests:MeasureReverseUsingNtoH():int[]:this'
-    [ 0]   0 (0x000) ldsfld 04000B90
-Checking if we can import 'static readonly' as a jit-time constant... 
-    [ 1]   5 (0x005) stloc.0Querying runtime about current class of field <unknown class>:<unknown field> (declared as int[])
-Runtime reports field is init-only and initialized and has class int[]
-
-lvaUpdateClass: Updating class for V01 from (00007FFAE8373060) int[] to (00007FFAE8373060) int[] [exact]
-
-
-STMT00000 ( 0x000[E-] ... ??? )
-               [000003] -A--G------                         ▌  ASG       ref   
-               [000002] D------N---                         ├──▌  LCL_VAR   ref    V01 loc0         
-               [000001] #---G------                         └──▌  IND       ref   
-               [000000] H----------                            └──▌  CNS_INT(h) long   0x1f0ccc06c08 const ptr Fseq[<unknown field>]

+Importing BB01 (PC=000) of 'System.Buffers.Binary.Tests.BinaryReadAndWriteTests:MeasureReverseUsingNtoH():int[]:this'
+    [ 0]   0 (0x000) ldsfld 04000B90
+Checking if we can import 'static readonly' as a jit-time constant... ... success! The value is:
+               [000000] H----------                         ▌  CNS_INT(h) ref   
+
+    [ 1]   5 (0x005) stloc.0
+
+STMT00000 ( 0x000[E-] ... ??? )
+               [000002] -A---------                         ▌  ASG       ref   
+               [000001] D------N---                         ├──▌  LCL_VAR   ref    V01 loc0         
+               [000000] H----------                         └──▌  CNS_INT(h) ref

`System.Buffers.Binary.Tests.BinaryReadAndWriteTests.MeasureReverseUsingNtoH`

Hot functions:

(96.83%) BinaryReadAndWriteTests.MeasureReverseUsingNtoH (Tier-1)
- Has diffs
(1.51%) Runnable_0.WorkloadActionUnroll (Tier-1)
- No diffs

Diffs

`[MicroBenchmarks]BinaryReadAndWriteTests.MeasureReverseUsingNtoH()`

 ; Final local variable assignments
 ;
 ;* V00 this         [V00    ] (  0,  0   )     ref  ->  zero-ref    this class-hnd single-def
-;  V01 loc0         [V01,T03] (  6, 10   )     ref  ->  rdx         class-hnd exact
+;  V01 loc0         [V01,T03] (  6, 10   )     ref  ->  rdx         class-hnd
 ;  V02 loc1         [V02,T00] ( 12, 18.08)     int  ->  rax        
 ;  V03 OutArgs      [V03    ] (  1,  1   )  struct (32) [rsp+00H]   do-not-enreg[XS] addr-exposed "OutgoingArgSpace"
 ;  V04 tmp1         [V04,T01] (  4, 16   )     int  ->   r9         "Strict ordering of exceptions for Array store"
@@ -175,36 +175,39 @@ G_M5635_IG08:
 ; Final local variable assignments
 ;
 ;* V00 this         [V00    ] (  0,  0   )     ref  ->  zero-ref    this class-hnd single-def
-;  V01 loc0         [V01,T03] (  4, 10   )     ref  ->  rax         class-hnd exact single-def
-;  V02 loc1         [V02,T00] (  5, 17   )     int  ->  rdx        
+;* V01 loc0         [V01,T03] (  0,  0   )     ref  ->  zero-ref    class-hnd single-def
+;  V02 loc1         [V02,T00] (  5, 17   )     int  ->  rax        
 ;# V03 OutArgs      [V03    ] (  1,  1   )  struct ( 0) [rsp+00H]   do-not-enreg[XS] addr-exposed "OutgoingArgSpace"
-;  V04 tmp1         [V04,T01] (  2, 16   )     int  ->   r8         "Strict ordering of exceptions for Array store"
+;  V04 tmp1         [V04,T01] (  2, 16   )     int  ->  rcx         "Strict ordering of exceptions for Array store"
 ;* V05 tmp2         [V05    ] (  0,  0   )     int  ->  zero-ref    "Inlining Arg"
 ;* V06 tmp3         [V06    ] (  0,  0   )     int  ->  zero-ref    "Inline return value spill temp"
-;  V07 cse0         [V07,T02] (  3, 12   )    long  ->  rcx         "CSE - aggressive"
+;  V07 cse0         [V07,T02] (  3, 12   )    long  ->  rdx         "CSE - aggressive"
 ;
 ; Lcl frame size = 0
 
 G_M5635_IG01:
 						;; size=0 bbWeight=1 PerfScore 0.00
 G_M5635_IG02:
-       mov      rax, 0xD1FFAB1E      ; const ptr
-       mov      rax, gword ptr [rax]
-       xor      edx, edx
-       align    [1 bytes for IG03]
-						;; size=16 bbWeight=1 PerfScore 2.75
+       xor      eax, eax
+       align    [0 bytes for IG03]
+						;; size=2 bbWeight=1 PerfScore 0.25
 G_M5635_IG03:
-       mov      ecx, edx
-       movbe    r8d, dword ptr [rax+4*rcx+10H]
-       mov      dword ptr [rax+4*rcx+10H], r8d
-       inc      edx
-       cmp      edx, 1
+       mov      edx, eax
+       mov      rcx, 0xD1FFAB1E
+       movbe    ecx, dword ptr [rcx+4*rdx]
+       mov      r8, 0xD1FFAB1E
+       mov      dword ptr [r8+4*rdx], ecx
+       inc      eax
+       cmp      eax, 1
        jl       SHORT G_M5635_IG03
-						;; size=21 bbWeight=4 PerfScore 23.00
+						;; size=38 bbWeight=4 PerfScore 25.00
 G_M5635_IG04:
+       mov      rax, 0xD1FFAB1E
+						;; size=10 bbWeight=1 PerfScore 0.25
+G_M5635_IG05:
        ret      
 						;; size=1 bbWeight=1 PerfScore 1.00
 
-; Total bytes of code 38, prolog size 0, PerfScore 30.55, instruction count 11, allocated bytes for code 38 (MethodHash=87c1e9fc) for method System.Buffers.Binary.Tests.BinaryReadAndWriteTests:MeasureReverseUsingNtoH():int[]:this
+; Total bytes of code 51, prolog size 0, PerfScore 31.60, instruction count 12, allocated bytes for code 51 (MethodHash=87c1e9fc) for method System.Buffers.Binary.Tests.BinaryReadAndWriteTests:MeasureReverseUsingNtoH():int[]:this
 ; ============================================================

`System.Buffers.Binary.Tests.BinaryReadAndWriteTests.MeasureReverseEndianness`

Hot functions:

(97.28%) BinaryReadAndWriteTests.MeasureReverseEndianness (Tier-1)
- Has diffs
(1.38%) Runnable_0.WorkloadActionUnroll (Tier-1)
- No diffs

Diffs

`[MicroBenchmarks]BinaryReadAndWriteTests.MeasureReverseEndianness()`

 ; Final local variable assignments
 ;
 ;* V00 this         [V00    ] (  0,  0   )     ref  ->  zero-ref    this class-hnd single-def
-;  V01 loc0         [V01,T03] (  6, 10   )     ref  ->  rdx         class-hnd exact
+;  V01 loc0         [V01,T03] (  6, 10   )     ref  ->  rdx         class-hnd
 ;  V02 loc1         [V02,T00] ( 12, 18.08)     int  ->  rax        
 ;  V03 OutArgs      [V03    ] (  1,  1   )  struct (32) [rsp+00H]   do-not-enreg[XS] addr-exposed "OutgoingArgSpace"
 ;  V04 tmp1         [V04,T01] (  4, 16   )     int  ->   r9         "Strict ordering of exceptions for Array store"
@@ -171,34 +171,37 @@ G_M42778_IG08:
 ; Final local variable assignments
 ;
 ;* V00 this         [V00    ] (  0,  0   )     ref  ->  zero-ref    this class-hnd single-def
-;  V01 loc0         [V01,T03] (  4, 10   )     ref  ->  rax         class-hnd exact single-def
-;  V02 loc1         [V02,T00] (  5, 17   )     int  ->  rdx        
+;* V01 loc0         [V01,T03] (  0,  0   )     ref  ->  zero-ref    class-hnd single-def
+;  V02 loc1         [V02,T00] (  5, 17   )     int  ->  rax        
 ;# V03 OutArgs      [V03    ] (  1,  1   )  struct ( 0) [rsp+00H]   do-not-enreg[XS] addr-exposed "OutgoingArgSpace"
-;  V04 tmp1         [V04,T01] (  2, 16   )     int  ->   r8         "Strict ordering of exceptions for Array store"
-;  V05 cse0         [V05,T02] (  3, 12   )    long  ->  rcx         "CSE - aggressive"
+;  V04 tmp1         [V04,T01] (  2, 16   )     int  ->  rcx         "Strict ordering of exceptions for Array store"
+;  V05 cse0         [V05,T02] (  3, 12   )    long  ->  rdx         "CSE - aggressive"
 ;
 ; Lcl frame size = 0
 
 G_M42778_IG01:
 						;; size=0 bbWeight=1 PerfScore 0.00
 G_M42778_IG02:
-       mov      rax, 0xD1FFAB1E      ; const ptr
-       mov      rax, gword ptr [rax]
-       xor      edx, edx
-       align    [1 bytes for IG03]
-						;; size=16 bbWeight=1 PerfScore 2.75
+       xor      eax, eax
+       align    [0 bytes for IG03]
+						;; size=2 bbWeight=1 PerfScore 0.25
 G_M42778_IG03:
-       mov      ecx, edx
-       movbe    r8d, dword ptr [rax+4*rcx+10H]
-       mov      dword ptr [rax+4*rcx+10H], r8d
-       inc      edx
-       cmp      edx, 1
+       mov      edx, eax
+       mov      rcx, 0xD1FFAB1E
+       movbe    ecx, dword ptr [rcx+4*rdx]
+       mov      r8, 0xD1FFAB1E
+       mov      dword ptr [r8+4*rdx], ecx
+       inc      eax
+       cmp      eax, 1
        jl       SHORT G_M42778_IG03
-						;; size=21 bbWeight=4 PerfScore 23.00
+						;; size=38 bbWeight=4 PerfScore 25.00
 G_M42778_IG04:
+       mov      rax, 0xD1FFAB1E
+						;; size=10 bbWeight=1 PerfScore 0.25
+G_M42778_IG05:
        ret      
 						;; size=1 bbWeight=1 PerfScore 1.00
 
-; Total bytes of code 38, prolog size 0, PerfScore 30.55, instruction count 11, allocated bytes for code 38 (MethodHash=bce858e5) for method System.Buffers.Binary.Tests.BinaryReadAndWriteTests:MeasureReverseEndianness():int[]:this
+; Total bytes of code 51, prolog size 0, PerfScore 31.60, instruction count 12, allocated bytes for code 51 (MethodHash=bce858e5) for method System.Buffers.Binary.Tests.BinaryReadAndWriteTests:MeasureReverseEndianness():int[]:this
 ; ============================================================

jakobbotsch · 2023-07-25T09:11:47Z

I'll actually leave this in 8.0 for a bit, maybe someone else has an idea about something we can do.

AndyAyersMS · 2023-07-25T15:28:34Z

Only seems to affect intel x64.

jakobbotsch · 2023-08-01T11:30:28Z

I think we should do something here, but I do not see any possible surgical fix. I think ideally this is fixed by 1) avoiding this propagation of constants into loops/higher weighted blocks in the first place, and 2) some rematerialization support for constants to not regress register allocation when we do 1.
Will move this to 9.0.

dotnet-policy-service · 2024-05-03T20:15:45Z

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

jakobbotsch · 2024-07-29T15:06:45Z

Moving to 10 for the same reason as the above. We sadly did not get around to revisiting some of the necessities for improving cases like this one.

performanceautofiler bot assigned AndyAyersMS May 9, 2023

performanceautofiler bot added arch-x64 os-windows runtime-coreclr specific to the CoreCLR runtime untriaged New issue has not been triaged by the area owner labels May 9, 2023

cincuranet removed the untriaged New issue has not been triaged by the area owner label May 9, 2023

cincuranet changed the title ~~[Perf] Windows/x64: 2 Regressions on 5/3/2023 1:06:54 PM~~ Regressions in System.Buffers.Binary.Tests.BinaryReadAndWriteTests May 9, 2023

cincuranet transferred this issue from dotnet/perf-autofiling-issues May 9, 2023

dotnet-issue-labeler bot added the area-System.Buffers label May 9, 2023

ghost added the untriaged New issue has not been triaged by the area owner label May 9, 2023

AndyAyersMS removed their assignment May 9, 2023

EgorBo mentioned this issue May 16, 2023

[Perf] Linux/arm64: 9 Regressions on 5/3/2023 4:46:09 PM dotnet/perf-autofiling-issues#17669

Closed

tannergooding removed the untriaged New issue has not been triaged by the area owner label May 26, 2023

ericstj added this to the 8.0.0 milestone Jul 24, 2023

jakobbotsch self-assigned this Jul 25, 2023

jakobbotsch modified the milestones: 8.0.0, 9.0.0 Aug 1, 2023

jakobbotsch mentioned this issue Aug 24, 2023

[Perf] Windows/x64: 2 Regressions on 5/3/2023 1:06:54 PM dotnet/perf-autofiling-issues#17524

Closed

DrewScoggins mentioned this issue Sep 5, 2023

[Perf] 7.0 -> 8.0-RC1 Microbenchmark Comparison #91626

Closed

jakobbotsch removed the area-System.Buffers label May 3, 2024

jakobbotsch added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label May 3, 2024

jakobbotsch modified the milestones: 9.0.0, 10.0.0 Jul 29, 2024

Regressions in System.Buffers.Binary.Tests.BinaryReadAndWriteTests #85988

Regressions in System.Buffers.Binary.Tests.BinaryReadAndWriteTests #85988

Comments

performanceautofiler bot commented May 9, 2023 • edited Loading

Run Information

Regressions in System.Buffers.Binary.Tests.BinaryReadAndWriteTests

Repro

Payloads

Payloads

Histogram

System.Buffers.Binary.Tests.BinaryReadAndWriteTests.MeasureReverseUsingNtoH

Description of detection logic

JIT Disasms

System.Buffers.Binary.Tests.BinaryReadAndWriteTests.MeasureReverseEndianness

Description of detection logic

JIT Disasms

Docs

ghost commented May 9, 2023

Run Information

Regressions in System.Buffers.Binary.Tests.BinaryReadAndWriteTests

Repro

Payloads

Payloads

Histogram

System.Buffers.Binary.Tests.BinaryReadAndWriteTests.MeasureReverseUsingNtoH

Description of detection logic

JIT Disasms

System.Buffers.Binary.Tests.BinaryReadAndWriteTests.MeasureReverseEndianness

Description of detection logic

JIT Disasms

Docs

cincuranet commented May 9, 2023 • edited Loading

jakobbotsch commented May 9, 2023

AndyAyersMS commented May 9, 2023

tannergooding commented Jul 24, 2023

jakobbotsch commented Jul 25, 2023

jakobbotsch commented Jul 25, 2023

System.Buffers.Binary.Tests.BinaryReadAndWriteTests.MeasureReverseUsingNtoH

[MicroBenchmarks]BinaryReadAndWriteTests.MeasureReverseUsingNtoH()

System.Buffers.Binary.Tests.BinaryReadAndWriteTests.MeasureReverseEndianness

[MicroBenchmarks]BinaryReadAndWriteTests.MeasureReverseEndianness()

jakobbotsch commented Jul 25, 2023

AndyAyersMS commented Jul 25, 2023

jakobbotsch commented Aug 1, 2023

dotnet-policy-service bot commented May 3, 2024

jakobbotsch commented Jul 29, 2024

performanceautofiler bot commented May 9, 2023 •

edited

Loading

cincuranet commented May 9, 2023 •

edited

Loading

`System.Buffers.Binary.Tests.BinaryReadAndWriteTests.MeasureReverseUsingNtoH`

`[MicroBenchmarks]BinaryReadAndWriteTests.MeasureReverseUsingNtoH()`

`System.Buffers.Binary.Tests.BinaryReadAndWriteTests.MeasureReverseEndianness`

`[MicroBenchmarks]BinaryReadAndWriteTests.MeasureReverseEndianness()`