Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NativeAOT] Possible perf improvements in casting #84464

Closed
VSadov opened this issue Apr 7, 2023 · 1 comment · Fixed by #90234
Closed

[NativeAOT] Possible perf improvements in casting #84464

VSadov opened this issue Apr 7, 2023 · 1 comment · Fixed by #90234
Assignees
@VSadov
Labels
area-NativeAOT-coreclr
Milestone
8.0.0

Comments

@VSadov
Copy link
Member

VSadov commented Apr 7, 2023 •
edited
Loading

CoreClr appears to have faster casting helpers than NativeAOT. #84430 (comment)

That means the NativeAOT helpers could likely be improved, since conceptually they should be applying similar logic.
It is worth compare the code of the helpers and related typesystem bits to see what can be copied/unified from whichever is a faster implementation.
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Apr 7, 2023
@ghost
Copy link

ghost commented Apr 7, 2023

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details

CoreClr appears to have faster casting helpers than in NativeAOT. #84430 (comment)

That means the NativeAOT helpers could likely be improved, since conceptually they should be applying similar logic.
It is worth compare the code of the helpers and related typesystem bits to see what can be copied/unified form the faster implementation.

Author: VSadov
Assignees: -
Labels:

untriaged, area-NativeAOT-coreclr
Milestone: -

@VSadov VSadov self-assigned this Apr 7, 2023
@agocke agocke added this to AppModel Apr 20, 2023
@VSadov VSadov assigned MichalStrehovsky and unassigned VSadov May 10, 2023
@VSadov VSadov mentioned this issue May 10, 2023
Merged
@VSadov VSadov assigned VSadov and unassigned MichalStrehovsky May 10, 2023
@agocke agocke added this to the 8.0.0 milestone Jun 21, 2023
@ghost ghost removed the untriaged New issue has not been triaged by the area owner label Jun 21, 2023
@VSadov VSadov mentioned this issue Jul 27, 2023
Closed
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Jul 27, 2023
@VSadov VSadov mentioned this issue Aug 9, 2023
Merged
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Aug 23, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@VSadov VSadov

Labels
area-NativeAOT-coreclr
Projects
AppModel
Archived in project
Milestone
8.0.0
3 participants
@agocke @VSadov @MichalStrehovsky