Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose System.Linq.Expressions.CanCompileToIL feature switch #79726

Open
MichalStrehovsky opened this issue Dec 16, 2022 · 3 comments
Open

Expose System.Linq.Expressions.CanCompileToIL feature switch #79726

MichalStrehovsky opened this issue Dec 16, 2022 · 3 comments
Labels
area-System.Linq.Expressions linkable-framework Issues associated with delivering a linker friendly framework
Milestone

Comments

@MichalStrehovsky
Copy link
Member

We should add an MSBuild property to allow turning this off and get rid of the IL emit backend.

We could optionally also expose a more general purpose <OptimizationPreference>Size</OptimizationPreference> property that would enable this one (and maybe others if we find more opportunities).

@MichalStrehovsky MichalStrehovsky added area-System.Linq.Expressions linkable-framework Issues associated with delivering a linker friendly framework labels Dec 16, 2022
@ghost
Copy link

ghost commented Dec 16, 2022

Tagging subscribers to this area: @cston
See info in area-owners.md if you want to be subscribed.

Issue Details

We should add an MSBuild property to allow turning this off and get rid of the IL emit backend.

We could optionally also expose a more general purpose <OptimizationPreference>Size</OptimizationPreference> property that would enable this one (and maybe others if we find more opportunities).

Author: MichalStrehovsky
Assignees: -
Labels:

area-System.Linq.Expressions, linkable-framework

Milestone: -

@ghost ghost added the untriaged New issue has not been triaged by the area owner label Dec 16, 2022
@teo-tsirpanis
Copy link
Contributor

We could optionally also expose a more general purpose <OptimizationPreference>Size</OptimizationPreference> property that would enable this one (and maybe others if we find more opportunities).

Yes please, I had mentioned it some time ago. Another use case for it would be LINQ, which uses a smaller but less optimized implementation on WASM.

@MichalStrehovsky
Copy link
Member Author

Another use case for it would be LINQ, which uses a smaller but less optimized implementation on WASM.

If you have a proposal for how that would be possible, I would be very interested in a feature switch for that (should be discussed in a separate issue). Currently it's only possible to build that flavor at C# compile time and it didn't look trivial to convert to feature switch (but I could be proved wrong on that).

@cston cston added this to the Future milestone Aug 14, 2024
@cston cston removed the untriaged New issue has not been triaged by the area owner label Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-System.Linq.Expressions linkable-framework Issues associated with delivering a linker friendly framework
Projects
None yet
Development

No branches or pull requests

3 participants