Regressions in System.IO.Tests.StreamReaderReadLineTests

[performanceautofiler]

Run Information

Architecture	arm64
OS	ubuntu 20.04
Baseline	264d7391ec9f6e698051db0621c5e090d0ae4710
Compare	c6549d9ef9f37539f8ea4c14073e75c7b69fbd23
Diff	Diff

Regressions in System.IO.Tests.StreamReaderReadLineTests

Benchmark	Baseline	Test	Test/Base	Test Quality	Edge Detector	Baseline IR	Compare IR	IR Ratio	Baseline ETL	Compare ETL
ReadLineAsync - Duration of single invocation	499.37 μs	657.01 μs	1.32	0.54	False

Test Report

Repro

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net6.0 --filter 'System.IO.Tests.StreamReaderReadLineTests*'

Related Issues

Regressions

Improvements

Payloads

Baseline
Compare

Histogram

Edge Detector Info

Collection Data

System.IO.Tests.StreamReaderReadLineTests.ReadLineAsync(LineLengthRange: [ 1, 1])

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionWindowed: Marked as regression because 657.0139359809027 > 538.9410800946029.
IsChangePoint: Marked as a change because one of 11/7/2022 10:11:20 AM, 11/9/2022 1:54:51 PM falls between 10/31/2022 10:23:25 PM and 11/9/2022 1:54:51 PM.
IsRegressionStdDev: Marked as regression because -4.333774935293708 (T) = (0 -639914.9845867202) / Math.Sqrt((1531601106.1976035 / (36)) + (2488868041.9799547 / (6))) is less than -2.0210753903043583 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (36) + (6) - 2, .025) and -0.16936390592883707 = (547233.3987240948 - 639914.9845867202) / 547233.3987240948 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

[ghost]

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Run Information

Architecture	arm64
OS	ubuntu 20.04
Baseline	264d7391ec9f6e698051db0621c5e090d0ae4710
Compare	c6549d9ef9f37539f8ea4c14073e75c7b69fbd23
Diff	Diff

Regressions in System.IO.Tests.StreamReaderReadLineTests

Benchmark	Baseline	Test	Test/Base	Test Quality	Edge Detector	Baseline IR	Compare IR	IR Ratio	Baseline ETL	Compare ETL
ReadLineAsync - Duration of single invocation	499.37 μs	657.01 μs	1.32	0.54	False

Test Report

Repro

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net6.0 --filter 'System.IO.Tests.StreamReaderReadLineTests*'

Related Issues

Regressions

Improvements

Payloads

Baseline
Compare

Histogram

Edge Detector Info

Collection Data

System.IO.Tests.StreamReaderReadLineTests.ReadLineAsync(LineLengthRange: [ 1, 1])

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionWindowed: Marked as regression because 657.0139359809027 > 538.9410800946029.
IsChangePoint: Marked as a change because one of 11/7/2022 10:11:20 AM, 11/9/2022 1:54:51 PM falls between 10/31/2022 10:23:25 PM and 11/9/2022 1:54:51 PM.
IsRegressionStdDev: Marked as regression because -4.333774935293708 (T) = (0 -639914.9845867202) / Math.Sqrt((1531601106.1976035 / (36)) + (2488868041.9799547 / (6))) is less than -2.0210753903043583 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (36) + (6) - 2, .025) and -0.16936390592883707 = (547233.3987240948 - 639914.9845867202) / 547233.3987240948 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

Author:	performanceautofiler[bot]
Assignees:	-
Labels:	area-System.IO
Milestone:	-

[EgorBo]

Likely regressed from #69888 cc @GrabYourPitchforks

[adamsitnik]

It's by design: #69888 has improved a lot of test cases:

dotnet/perf-autofiling-issues#9681
dotnet/perf-autofiling-issues#9680

but regressed this one, which is about reading very short lines (1 character). I think it's acceptable.

cc @stephentoub

[stephentoub]

I think it's acceptable.

Yup. We had a similar conversation and outcome when similar changes to use IndexOf{Any} were made to StringReader.
#60463