EventSourceLogger does not propagate SpanId and TraceId

[wiktork]

Description

Asp.net log scope data collected from an out of process collector such as dotnet-monitor no longer contains Activity information such as TraceId and SpanId. These properties are no longer added as part of the Request scope data (see dotnet/aspnetcore#22376). These properties are no added to loggers using IExternalScopeProvider/ISupportExternalScope, which EventSourceLogger does not support.

Related dotnet-monitor issue dotnet/dotnet-monitor#2545

Reproduction Steps

Create a new asp.net core 6.0 web application.
Install dotnet-monitor tool
Run dotnet-monitor collect --no-auth
Run curl https://localhost:52323/logs?level=Information&pid=<pid of web app>
Issue a request to the web app.

Expected behavior

Log from dotnet-monitor should contain SpanId and TraceId information

Actual behavior

Log entry contains RequestId and RequestPath, but no activity information is displayed.

Regression?

Yes; this behavior worked in 3.1

Known Workarounds

No response

Configuration

Windows .Net 6 x64

The issue is specific to net 6+.

Other information

No response

[dotnet-issue-labeler]

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

[ghost]

Tagging subscribers to this area: @dotnet/area-extensions-logging
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Description

Asp.net log scope data collected from an out of process collector such as dotnet-monitor no longer contains Activity information such as TraceId and SpanId. These properties are no longer added as part of the Request scope data (see dotnet/aspnetcore#22376). These properties are no added to loggers using IExternalScopeProvider/ISupportExternalScope, which EventSourceLogger does not support.

Related dotnet-monitor issue dotnet/dotnet-monitor#2545

Reproduction Steps

Create a new asp.net core 6.0 web application.
Install dotnet-monitor tool
Run dotnet-monitor collect --no-auth
Run curl https://localhost:52323/logs?level=Information&pid=<pid of web app>
Issue a request to the web app.

Expected behavior

Log from dotnet-monitor should contain SpanId and TraceId information

Actual behavior

Log entry contains RequestId and RequestPath, but no activity information is displayed.

Regression?

Yes; this behavior worked in 3.1

Known Workarounds

No response

Configuration

Windows .Net 6 x64

The issue is specific to net 6+.

Other information

No response

Author:	wiktork
Assignees:	-
Labels:	untriaged, area-Extensions-Logging
Milestone:	-

[CodeBlanch]

@tarekgh @noahfalk @samsp-msft

It may be a good idea to implement ISupportExternalScope on EventSourceLoggerProvider as a perf improvement but I think for correlation what we should do is add TraceId, SpanId, and ActivityTraceFlags from Activity.Current as fields on the events emitted by LoggingEventSource.

The reason is, users may not want scopes. In OTel we don't recommend scopes at all. Users who have enabled scopes have complained about the amount of data that appears because AspNetCore creates some scopes automatically.

Why TraceId, SpanId, and ActivityTraceFlags? From an OTel perspective those are the trace context fields added to logs for correlation: https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/logs/data-model.md#log-and-event-record-definition

Also I think we might want to try and get this into .NET 9. We're working on solving out of process monitoring and correlation is very important to that scenario.