[mono]pack nuget packages with -cmakeargs orrcured error on windows.

[srxqds]

Description

when I build to generate package with -cmakeargs, it hit error:

./build.cmd -pack -runtimeFlavor mono /p:Deterministic=true -cmakeargs -DENABLE_OVERRIDABLE_ALLOCATORS=1 -c Release -v d

but it can build successful using:

./build.cmd mono+libs -c Release

./build.cmd -pack -runtimeFlavor mono /p:Deterministic=true -cmakeargs -DENABLE_OVERRIDABLE_ALLOCATORS=1

Reproduction Steps

./build.cmd -pack -runtimeFlavor mono /p:Deterministic=true -cmakeargs -DENABLE_OVERRIDABLE_ALLOCATORS=1 -c Release

Expected behavior

build success

Actual behavior

hit error.

Regression?

No response

Known Workarounds

No response

Configuration

No response

Other information

No response

[dotnet-issue-labeler]

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

[srxqds]

below is the log build with -pack and -cmakeargs
log.txt

found the problem is not fond zlib

Could NOT find ZLIB (missing: ZLIB_LIBRARY ZLIB_INCLUDE_DIR)
Call Stack (most recent call first):
C:/Program Files/CMake/share/cmake-3.24/Modules/FindPackageHandleStandardArgs.cmake:594 (_FPHSA_FAILURE_MESSAGE)
C:/Program Files/CMake/share/cmake-3.24/Modules/FindZLIB.cmake:166 (FIND_PACKAGE_HANDLE_STANDARD_ARGS)
F:/netease-gitlab/dotnet/runtime/src/native/libs/System.IO.Compression.Native/extra_libs.cmake:12 (find_package)
F:/netease-gitlab/dotnet/runtime/src/native/corehost/apphost/static/CMakeLists.txt:151 (append_extra_compression_libs)

and build_log.txt is the log using ./build.cmd mono+libs -c Release
build_log.txt

[srxqds]

@akoeplinger could you help me?

the problem is there are two cmake define pass with one -cmakeargs:

F:\netease-gitlab\dotnet\runtime\src\coreclr\runtime.proj(61,5): error MSB3073: The command ""F:\netease-gitlab\dotnet\runtime\src\coreclr\build-runtime.cmd" -x64 -cmakeargs "-DENABLE_OVERRIDABLE_ALLOCATORS=1 -DCLR_CROSS_COMPONENTS_BUILD=1" -release -os Linux -hostarch x64 -component crosscomponents" exited with code 1.

but I am not an expert in windows batch or msbuild script, so I can't fix it, hope you can take the time to fix it.

[akoeplinger]

Hmm it looks like there's some issue with passing this to the coreclr build?
If you want to just experiment then you can add the define here instead:

runtime/src/mono/mono.proj

Line 217 in eb02b20

<_MonoCMakeArgs Include="-DMONO_SHARED_LIB_NAME=$(MonoSharedLibName)" />

[srxqds]

yeah, it can be fixed by adding define in CMakeList.txt or mono.proj file directly.
I think we the problem is introduced at this line:

runtime/src/coreclr/build-runtime.cmd

Line 356 in 415a417

set __ExtraCmakeArgs=!__ExtraCmakeArgs! "-DCLR_CMAKE_TARGET_ARCH=%__TargetArch%" "-DCLR_CMAKE_TARGET_OS=%__TargetOS%" "-DCLR_CMAKE_PGO_INSTRUMENT=%__PgoInstrument%" "-DCLR_CMAKE_OPTDATA_PATH=%__PgoOptDataPath%" "-DCLR_CMAKE_PGO_OPTIMIZE=%__PgoOptimize%" %__CMakeArgs%

we should append __ExtraCmakeArgs with "-DENABLE_OVERRIDABLE_ALLOCATORS=1" "-DCLR_CROSS_COMPONENTS_BUILD=1" instead of "-DENABLE_OVERRIDABLE_ALLOCATORS=1 -DCLR_CROSS_COMPONENTS_BUILD=1"

I have tryed but not work