Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ObjectDisposedException triple slash from CancellationToken.ThrowIfCancellationRequested #66369

Closed
carlossanlop opened this issue Mar 9, 2022 · 1 comment · Fixed by #66399
Closed

Remove ObjectDisposedException triple slash from CancellationToken.ThrowIfCancellationRequested #66369

carlossanlop opened this issue Mar 9, 2022 · 1 comment · Fixed by #66399
Assignees
@kouvel
Labels
area-System.Threading documentation Documentation bug or enhancement, does not impact product or test code
Milestone
7.0.0

Comments

@carlossanlop
Copy link
Member

From this discussion: https://github.com/dotnet/dotnet-api-docs/pull/7807/files#r822056944

This exception needs to be removed from triple slash comments since it is not thrown by the method. This will ensure we don't accidentally port it back to dotnet-api-docs, considering we run a tool to port source documentation to api docs.

@kouvel

Source that needs to be removed:
https://github.com/dotnet/runtime/blob/main/src%2Flibraries%2FSystem.Private.CoreLib%2Fsrc%2FSystem%2FThreading%2FCancellationToken.cs#L354
@ghost
Copy link

ghost commented Mar 9, 2022

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

Issue Details

From this discussion: https://github.com/dotnet/dotnet-api-docs/pull/7807/files#r822056944

This exception needs to be removed from triple slash comments since it is not thrown by the method. This will ensure we don't accidentally port it back to dotnet-api-docs, considering we run a tool to port source documentation to api docs.

@kouvel

Source that needs to be removed:
https://github.com/dotnet/runtime/blob/main/src%2Flibraries%2FSystem.Private.CoreLib%2Fsrc%2FSystem%2FThreading%2FCancellationToken.cs#L354

Author: carlossanlop
Assignees: -
Labels:

area-System.Threading
Milestone: -

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Mar 9, 2022
@carlossanlop carlossanlop added the documentation Documentation bug or enhancement, does not impact product or test code label Mar 9, 2022
@carlossanlop carlossanlop mentioned this issue Mar 9, 2022
Merged
@kouvel kouvel added this to the 7.0.0 milestone Mar 9, 2022
@kouvel kouvel removed the untriaged New issue has not been triaged by the area owner label Mar 9, 2022
@kouvel kouvel self-assigned this Mar 9, 2022
@AaronRobinsonMSFT AaronRobinsonMSFT mentioned this issue Mar 9, 2022
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Mar 9, 2022
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Mar 9, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Apr 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kouvel kouvel

Labels
area-System.Threading documentation Documentation bug or enhancement, does not impact product or test code
Projects
None yet
Milestone
7.0.0
Development

Successfully merging a pull request may close this issue.

Update CancellationToken.cs dotnet/runtime
2 participants
@carlossanlop @kouvel