Review workaround for ProcessEvent when event source is disabled

[jeffhandley]

Cleanup Issue-URLs in Code · Issue #63902 · dotnet/runtime identified a workaround that was applied to ProcessEvent for when event source is disabled via a feature switch. The comment indicates the "simple fix" should be reconsidered once #43657 is done. That issue has been closed, but it's unclear if this workaround is still necessary.

• The referenced issue is: Define and implement behavior of tracing functionality when EventSource is disabled via a feature switch · Issue #43657 · dotnet/runtime
• The PR that introduced this workaround was: Correctly apply EventSourceSupport feature switch to NativeRuntimeEventSource by vitek-karas · Pull Request #43602 · dotnet/runtime

runtime/src/libraries/System.Private.CoreLib/src/System/Diagnostics/Tracing/NativeRuntimeEventSource.cs

Lines 40 to 44 in f04a242

	{
	// A simple fix to avoid dependencies brought by this method if event source is disabled via a feature switch.
	// Should be reconsidered when https://github.com/dotnet/runtime/issues/43657 is done.
	if (!IsSupported)
	{

The applied fix should be reconsidered per the comment to determine if a different fix should be made. With the findings we should either apply a different fix, update the comment to reflect it's a permanent fix as-is, or update the code comment to reference this open issue for tracking.

/cc @deeprobin

[ghost]

Tagging subscribers to this area: @tarekgh, @tommcdon, @pjanotti
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Cleanup Issue-URLs in Code · Issue #63902 · dotnet/runtime identified a workaround that was applied to ProcessEvent for when event source is disabled via a feature switch. The comment indicates the "simple fix" should be reconsidered once #43657 is done. That issue has been closed, but it's unclear if this workaround is still necessary.

• The referenced issue is: Define and implement behavior of tracing functionality when EventSource is disabled via a feature switch · Issue #43657 · dotnet/runtime
• The PR that introduced this workaround was: Correctly apply EventSourceSupport feature switch to NativeRuntimeEventSource by vitek-karas · Pull Request #43602 · dotnet/runtime

runtime/src/libraries/System.Private.CoreLib/src/System/Diagnostics/Tracing/NativeRuntimeEventSource.cs

Lines 40 to 44 in f04a242

	{
	// A simple fix to avoid dependencies brought by this method if event source is disabled via a feature switch.
	// Should be reconsidered when https://github.com/dotnet/runtime/issues/43657 is done.
	if (!IsSupported)
	{

The applied fix should be reconsidered per the comment to determine if a different fix should be made. With the findings we should either apply a different fix, update the comment to reflect it's a permanent fix as-is, or update the code comment to reference this open issue for tracking.

/cc @deeprobin

Author:	jeffhandley
Assignees:	-
Labels:	area-System.Diagnostics.Tracing
Milestone:	-

[tommcdon]

@hoyosjs