Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[QUIC] Missing implementation for LocalCertificateSelectionCallback #65439

Open
ManickaP opened this issue Feb 16, 2022 · 2 comments
Open

[QUIC] Missing implementation for LocalCertificateSelectionCallback #65439

ManickaP opened this issue Feb 16, 2022 · 2 comments
Labels
area-System.Net.Quic tracking-external-issue The issue is caused by external problem (e.g. OS) - nothing we can do to fix it directly
Milestone
Future

Comments

@ManickaP
Copy link
Member

microsoft/msquic#1249
@dotnet-issue-labeler dotnet-issue-labeler bot added area-System.Net.Quic untriaged New issue has not been triaged by the area owner labels Feb 16, 2022
@ghost
Copy link

ghost commented Feb 16, 2022

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

microsoft/msquic#1249

Author: ManickaP
Assignees: -
Labels:

untriaged, area-System.Net.Quic
Milestone: -

@ManickaP ManickaP added the tracking-external-issue The issue is caused by external problem (e.g. OS) - nothing we can do to fix it directly label Feb 16, 2022
@ManickaP ManickaP added this to the 7.0.0 milestone Feb 16, 2022
@ManickaP ManickaP removed the untriaged New issue has not been triaged by the area owner label Feb 16, 2022
@karelz karelz modified the milestones: 7.0.0, Future Jun 13, 2022
@karelz karelz mentioned this issue Jun 13, 2022
Closed
@karelz
Copy link
Member

karelz commented Jun 13, 2022

Triage: This was broken on Linux prior to 7.0 for SslStream (we called the callback prior to handshake without info about trusted certs from server), we fixed it in 7.0. On Windows we didn't pass server certificate even on Windows prior to 7.0.
It is not recommended practice as it leaks some server info pontetially.

As a result we will call the callback before handshake via msquic (tracked by #70651) and wait for customers to ask for this feature (and work with msquic on that then).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-System.Net.Quic tracking-external-issue The issue is caused by external problem (e.g. OS) - nothing we can do to fix it directly
Projects
None yet
Milestone
Future
Development

No branches or pull requests
2 participants
@karelz @ManickaP