Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm] make emscripten symbols exportable #65436

Closed
pavelsavara opened this issue Feb 16, 2022 · 2 comments · Fixed by #66868
Closed

[wasm] make emscripten symbols exportable #65436

pavelsavara opened this issue Feb 16, 2022 · 2 comments · Fixed by #66868
Assignees
@pavelsavara
Labels
arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript
Milestone
7.0.0

Comments

@pavelsavara
Copy link
Member

  • add exports: string[] option to DotnetModuleConfig of createDotnetRuntime
    • which takes any symbols which are on global scope when emscripten is not modularized.
    • adds them to Module export
  • when disableDotnet6Compatibility==false export those symbols also to globalThis
@pavelsavara pavelsavara added this to the 7.0.0 milestone Feb 16, 2022
@pavelsavara pavelsavara self-assigned this Feb 16, 2022
@ghost
Copy link

ghost commented Feb 16, 2022

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details
  • add exports: string[] option to DotnetModuleConfig of createDotnetRuntime
    • which takes any symbols which are on global scope when emscripten is not modularized.
    • adds them to Module export
  • when disableDotnet6Compatibility==false export those symbols also to globalThis
Author: pavelsavara
Assignees: pavelsavara
Labels:

arch-wasm, area-System.Runtime.InteropServices.JavaScript
Milestone: 7.0.0

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Feb 16, 2022
@pavelsavara pavelsavara removed the untriaged New issue has not been triaged by the area owner label Feb 16, 2022
@pavelsavara
Copy link
Member Author

cc @jeromelaban

@jeromelaban jeromelaban mentioned this issue Feb 23, 2022
Merged
@jeromelaban jeromelaban mentioned this issue Mar 19, 2022
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Mar 19, 2022
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Mar 29, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pavelsavara pavelsavara

Labels
arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript
Projects
None yet
Milestone
7.0.0
Development

Successfully merging a pull request may close this issue.

feat: Add support for emscripten module exports jeromelaban/runtime
1 participant
@pavelsavara