Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EventSource_SuccessfulHandshake_LogsStartStop failures on Windows11 #63008

Closed
antonfirsov opened this issue Dec 20, 2021 · 4 comments · Fixed by #65105
Closed

EventSource_SuccessfulHandshake_LogsStartStop failures on Windows11 #63008

antonfirsov opened this issue Dec 20, 2021 · 4 comments · Fixed by #65105
Labels
area-System.Net.Security test-bug Problem in test source code (most likely) test-run-core Test failures in .NET Core test runs
Milestone

Comments

@antonfirsov
Copy link
Member

antonfirsov commented Dec 20, 2021

Impacted test: EventSource_SuccessfulHandshake_LogsStartStop

We throw a [SkipTestException] from an inner call to SslStream_StreamToStream_Authentication_Success (#59135):

await test.SslStream_StreamToStream_Authentication_Success();

But it looks like it's not being propagated because of RemoteExecutor:
https://helixre8s23ayyeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-62870-merge-83671b73f8b34d3085/System.Net.Security.Tests/2/console.ae014fcd.log?sv=2019-07-07&se=2022-01-06T22%3A03%3A15Z&sr=c&sp=rl&sig=baGyxGNbdVauzUOgTjrUPFOLeR4fZlOgkWOSBATBEBs%3D

I don't understand why is this failure intermittent.

@dotnet-issue-labeler dotnet-issue-labeler bot added area-System.Net.Security untriaged New issue has not been triaged by the area owner labels Dec 20, 2021
@ghost
Copy link

ghost commented Dec 20, 2021

Tagging subscribers to this area: @dotnet/ncl, @vcsjones
See info in area-owners.md if you want to be subscribed.

Issue Details

We throw a [SkipTestException] from an inner call to SslStream_StreamToStream_Authentication_Success (#59135):

await test.SslStream_StreamToStream_Authentication_Success();

But it looks like it's not being propagated because of RemoteExecutor:
https://helixre8s23ayyeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-62870-merge-83671b73f8b34d3085/System.Net.Security.Tests/2/console.ae014fcd.log?sv=2019-07-07&se=2022-01-06T22%3A03%3A15Z&sr=c&sp=rl&sig=baGyxGNbdVauzUOgTjrUPFOLeR4fZlOgkWOSBATBEBs%3D

I don't understand why is this failure intermittent.

Author: antonfirsov
Assignees: -
Labels:

area-System.Net.Security, untriaged

Milestone: -

@antonfirsov antonfirsov added the test-run-core Test failures in .NET Core test runs label Dec 20, 2021
@karelz karelz added the test-bug Problem in test source code (most likely) label Jan 4, 2022
@karelz karelz added this to the 7.0.0 milestone Jan 4, 2022
@karelz karelz removed the untriaged New issue has not been triaged by the area owner label Jan 4, 2022
@karelz
Copy link
Member

karelz commented Jan 4, 2022

Triage: We now disabled the inner test via SkipTestException on Win11 and we should deal with that reasonably in this test.

@wfurt
Copy link
Member

wfurt commented Feb 9, 2022

The SkipTestException is processed by our custom extension inside xUnit. When used within RemoteExecutor it will throw and kill the process on unhandled exception.
If the test is supposed to be skipped it needs to be done before or outside of the remote exec.

@wfurt
Copy link
Member

wfurt commented Feb 9, 2022

BTW as the last part @antonfirsov: that test depends on timing and it is not deterministic. I know @MihaZupan put in some effort to make this more stable but I'm not sure if we can really make 100% reliable. Perhaps inject some EOF sentinel and wait with asserts until we get it.

@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Feb 9, 2022
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Feb 10, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Mar 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Net.Security test-bug Problem in test source code (most likely) test-run-core Test failures in .NET Core test runs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants