Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up some RegexNode code #62651

Closed
stephentoub opened this issue Dec 10, 2021 · 1 comment · Fixed by #64074
Closed

Clean up some RegexNode code #62651

stephentoub opened this issue Dec 10, 2021 · 1 comment · Fixed by #64074
Assignees
@stephentoub
Labels
area-System.Text.RegularExpressions
Milestone
7.0.0

Comments

@stephentoub
Copy link
Member

  • RegexNode.Next should probably be renamed to Parent
  • RegexNode defines a bunch of const values used for RegexNode.Type values. These should be extracted into a RegexNodeType or RegexNodeKind enum.
@stephentoub stephentoub added this to the 7.0.0 milestone Dec 10, 2021
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Dec 10, 2021
@ghost
Copy link

ghost commented Dec 10, 2021

Tagging subscribers to this area: @dotnet/area-system-text-regularexpressions
See info in area-owners.md if you want to be subscribed.

Issue Details
  • RegexNode.Next should probably be renamed to Parent
  • RegexNode defines a bunch of const values used for RegexNode.Type values. These should be extracted into a RegexNodeType or RegexNodeKind enum.
Author: stephentoub
Assignees: -
Labels:

area-System.Text.RegularExpressions
Milestone: 7.0.0

@stephentoub stephentoub mentioned this issue Dec 10, 2021
Merged
@joperezr joperezr mentioned this issue Dec 14, 2021
Closed
48 tasks
@jeffschwMSFT jeffschwMSFT removed the untriaged New issue has not been triaged by the area owner label Jan 11, 2022
@stephentoub stephentoub self-assigned this Jan 20, 2022
@stephentoub stephentoub mentioned this issue Jan 20, 2022
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Jan 20, 2022
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Jan 21, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Feb 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@stephentoub stephentoub

Labels
area-System.Text.RegularExpressions
Projects
None yet
Milestone
7.0.0
Development

Successfully merging a pull request may close this issue.

RegexNode cleanup stephentoub/runtime
2 participants
@stephentoub @jeffschwMSFT