Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port pcre2 regex tests #61893

Closed
stephentoub opened this issue Nov 21, 2021 · 2 comments · Fixed by #73323
Closed

Port pcre2 regex tests #61893

stephentoub opened this issue Nov 21, 2021 · 2 comments · Fixed by #73323
Assignees
@joperezr
Labels
area-System.Text.RegularExpressions help wanted [up-for-grabs] Good issue for external contributors
Milestone
7.0.0

Comments

@stephentoub
Copy link
Member

PCRE has lots of regex functional tests we should port over to improve our coverage and help maintain/validate compatibility:
https://github.com/PhilipHazel/pcre2/tree/master/testdata, e.g.
https://github.com/PhilipHazel/pcre2/blob/eb42305f072549facb3293f392f25768f35fa218/testdata/testoutput1
@stephentoub stephentoub added this to the .NET 7.0 milestone Nov 21, 2021
@ghost
Copy link

ghost commented Nov 21, 2021

Tagging subscribers to this area: @eerhardt, @dotnet/area-system-text-regularexpressions
See info in area-owners.md if you want to be subscribed.

Issue Details

PCRE has lots of regex functional tests we should port over to improve our coverage and help maintain/validate compatibility:
https://github.com/PhilipHazel/pcre2/tree/master/testdata, e.g.
https://github.com/PhilipHazel/pcre2/blob/eb42305f072549facb3293f392f25768f35fa218/testdata/testoutput1

Author: stephentoub
Assignees: -
Labels:

area-System.Text.RegularExpressions
Milestone: .NET 7.0

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Nov 21, 2021
@stephentoub stephentoub added the help wanted [up-for-grabs] Good issue for external contributors label Nov 22, 2021
@jeffhandley jeffhandley modified the milestones: .NET 7.0, 7.0.0 Nov 22, 2021
@ghost ghost removed the untriaged New issue has not been triaged by the area owner label Nov 22, 2021
@joperezr joperezr mentioned this issue Dec 14, 2021
Closed
48 tasks
@stephentoub
Copy link
Member Author

PCRE.NET has test support for parsing pcre's testdata files:
https://github.com/ltrzesniewski/pcre-net/tree/4fc7fb590a774070534177727c0ce9c43a8c4d90/src/PCRE.NET.Tests/Pcre

@joperezr joperezr self-assigned this Jul 20, 2022
@joperezr joperezr mentioned this issue Aug 3, 2022
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Aug 3, 2022
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Aug 5, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Sep 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joperezr joperezr

Labels
area-System.Text.RegularExpressions help wanted [up-for-grabs] Good issue for external contributors
Projects
None yet
Milestone
7.0.0
Development

Successfully merging a pull request may close this issue.

Adding PCRE2 tests to increase Regex code coverage joperezr/runtime
3 participants
@jeffhandley @stephentoub @joperezr