Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dictionaryexpansion tests failing on Mono #61322

Closed
runfoapp bot opened this issue Nov 8, 2021 · 4 comments · Fixed by #61432
Closed

dictionaryexpansion tests failing on Mono #61322

runfoapp bot opened this issue Nov 8, 2021 · 4 comments · Fixed by #61432
Labels
area-AssemblyLoader-mono blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms'

Comments

@runfoapp
Copy link

runfoapp bot commented Nov 8, 2021 •
edited
Loading

Runfo Tracking Issue: dictionaryexpansion tests failing on mono

Build Definition Kind Run Name Console Core Dump Test Results Run Client
1463637 runtime Rolling Mono Android x64 Release @ Ubuntu.1804.Amd64.Android.29.Open console.log runclient.py
1462920 runtime PR 60879 Mono Android x64 Release @ Ubuntu.1804.Amd64.Android.29.Open console.log runclient.py
1462569 runtime Rolling Mono Android x64 Release @ Ubuntu.1804.Amd64.Android.29.Open console.log runclient.py
1462387 runtime PR 61030 CoreCLR Linux arm64 Checked @ (Ubuntu.1804.Arm64.Open)[email protected]/dotnet-buildtools/prereqs:ubuntu-18.04-helix-arm64v8-20210531091519-97d8652 console.log core dump runclient.py
1462387 runtime PR 61030 CoreCLR Linux arm64 Checked no_tiered_compilation @ (Ubuntu.1804.Arm64.Open)[email protected]/dotnet-buildtools/prereqs:ubuntu-18.04-helix-arm64v8-20210531091519-97d8652 console.log core dump runclient.py
1461465 runtime Rolling Mono Android x64 Release @ Ubuntu.1804.Amd64.Android.29.Open console.log runclient.py
1461427 runtime Rolling Mono Android x64 Release @ Ubuntu.1804.Amd64.Android.29.Open console.log runclient.py
1461256 runtime PR 60879 Mono Android x64 Release @ Ubuntu.1804.Amd64.Android.29.Open console.log runclient.py
1460580 runtime Rolling Mono Android x64 Release @ Ubuntu.1804.Amd64.Android.29.Open console.log runclient.py
1459735 runtime PR 60879 Mono Android x64 Release @ Ubuntu.1804.Amd64.Android.29.Open console.log runclient.py
1459618 runtime Rolling Mono Android x64 Release @ Ubuntu.1804.Amd64.Android.29.Open console.log runclient.py
1458701 runtime Rolling Mono Android x64 Release @ Ubuntu.1804.Amd64.Android.29.Open console.log runclient.py
1458388 runtime Rolling Mono Android x64 Release @ Ubuntu.1804.Amd64.Android.29.Open console.log runclient.py
1458188 runtime Rolling Mono Android x64 Release @ Ubuntu.1804.Amd64.Android.29.Open console.log runclient.py
1457989 runtime Rolling Mono Android x64 Release @ Ubuntu.1804.Amd64.Android.29.Open console.log runclient.py

Build Result Summary

Day Hit Count Week Hit Count Month Hit Count
4 14 14
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Nov 8, 2021
@agocke agocke changed the title loader/classloader/dictionaryexpansion/dictionaryexpansion/dictionaryexpansion.sh dictionaryexpansion tests failing on Mono Nov 8, 2021
@agocke agocke added area-AssemblyLoader-mono blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' and removed untriaged New issue has not been triaged by the area owner labels Nov 8, 2021
@ghost
Copy link

ghost commented Nov 8, 2021

Tagging subscribers to this area:
See info in area-owners.md if you want to be subscribed.

Issue Details

Runfo Tracking Issue: loader/classloader/dictionaryexpansion/dictionaryexpansion/dictionaryexpansion.sh

Build Definition Kind Run Name Console Core Dump Test Results Run Client
1458701 runtime Rolling Mono Android x64 Release @ Ubuntu.1804.Amd64.Android.29.Open console.log runclient.py
1458388 runtime Rolling Mono Android x64 Release @ Ubuntu.1804.Amd64.Android.29.Open console.log runclient.py
1458188 runtime Rolling Mono Android x64 Release @ Ubuntu.1804.Amd64.Android.29.Open console.log runclient.py
1457989 runtime Rolling Mono Android x64 Release @ Ubuntu.1804.Amd64.Android.29.Open console.log runclient.py

Build Result Summary

Day Hit Count Week Hit Count Month Hit Count
2 4 4
Author: runfoapp[bot]
Assignees: -
Labels:

blocking-clean-ci, area-AssemblyLoader-mono
Milestone: -

@runfoapp runfoapp bot mentioned this issue Nov 8, 2021
Closed
@jkoritzinsky jkoritzinsky mentioned this issue Nov 8, 2021
Closed
agocke added a commit to agocke/runtime that referenced this issue Nov 10, 2021
@agocke
Add activeissues.targets and disable test
5de3e0e 
activeissues.targets is meant to only disable CI-blocking tests. This PR also
skips the DictionaryExpansion tests on Mono Android to address dotnet#61322
@agocke agocke mentioned this issue Nov 10, 2021
Closed
@lambdageek
Copy link
Member

The underlying issue is discussed in #61299 (comment) - we need to package the xunit.assert with runtime tests that use xunit-style assertions

jkoritzinsky added a commit that referenced this issue Nov 10, 2021
@jkoritzinsky
Include the "TargetingPack" folder in the mobile apps.
d4dc931 
Fixes #61322
Fixes #61299
@jkoritzinsky jkoritzinsky mentioned this issue Nov 10, 2021
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Nov 10, 2021
@jkoritzinsky
Copy link
Member

A fix is out in #61432

jkoritzinsky added a commit that referenced this issue Nov 11, 2021
@jkoritzinsky
Include the "TargetingPack" folder in the mobile apps. (#61432)
6f5de0b 
Fixes #61322
Fixes #61299
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Nov 11, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Dec 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-AssemblyLoader-mono blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms'
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Include the "TargetingPack" folder in the mobile apps. dotnet/runtime
3 participants
@lambdageek @agocke @jkoritzinsky