Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regressions in System.Collections.CtorFromCollection<String> #60627

Closed
performanceautofiler bot opened this issue Oct 19, 2021 · 3 comments · Fixed by #60721
Closed

Regressions in System.Collections.CtorFromCollection<String> #60627

performanceautofiler bot opened this issue Oct 19, 2021 · 3 comments · Fixed by #60721
Assignees
@jakobbotsch
Labels
arch-x64 area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI os-alpine tenet-performance Performance related issue tenet-performance-benchmarks Issue from performance benchmark
Milestone
7.0.0

Comments

@performanceautofiler
Copy link

Run Information

Architecture x64
OS alpine 3.12
Baseline 11742903dcc40a55e8688a1c61291459215f8ed0
Compare f40247e8e4276ec4472eaeaac461bb3bc14c2cd0
Diff Diff

Regressions in System.Collections.CtorFromCollection<String>

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio Baseline ETL Compare ETL
ImmutableList - Duration of single invocation 9.61 μs 10.42 μs 1.08 0.05 False

graph
Test Report

Repro

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net6.0 --filter 'System.Collections.CtorFromCollection&lt;String&gt;*'

Payloads

Baseline
Compare

Histogram

System.Collections.CtorFromCollection<String>.ImmutableList(Size: 512)

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository
@kunalspathak kunalspathak changed the title [Perf] Changes at 10/15/2021 8:02:10 AM Regressions in System.Collections.CtorFromCollection<String> Oct 19, 2021
@kunalspathak kunalspathak transferred this issue from dotnet/perf-autofiling-issues Oct 19, 2021
@dotnet-issue-labeler dotnet-issue-labeler bot added area-System.Collections untriaged New issue has not been triaged by the area owner labels Oct 19, 2021
@ghost
Copy link

ghost commented Oct 19, 2021

Tagging subscribers to this area: @dotnet/area-system-collections
See info in area-owners.md if you want to be subscribed.

Issue Details

Run Information

Architecture x64
OS alpine 3.12
Baseline 11742903dcc40a55e8688a1c61291459215f8ed0
Compare f40247e8e4276ec4472eaeaac461bb3bc14c2cd0
Diff Diff

Regressions in System.Collections.CtorFromCollection<String>

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio Baseline ETL Compare ETL
ImmutableList - Duration of single invocation 9.61 μs 10.42 μs 1.08 0.05 False

graph
Test Report

Repro

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net6.0 --filter 'System.Collections.CtorFromCollection&lt;String&gt;*'

Payloads

Baseline
Compare

Histogram

System.Collections.CtorFromCollection<String>.ImmutableList(Size: 512)

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

Author: performanceautofiler[bot]
Assignees: -
Labels:

area-System.Collections, untriaged
Milestone: -

@kunalspathak
Copy link
Member

Caused by #59602
@jakobbotsch

@kunalspathak kunalspathak added arch-x64 area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI os-alpine labels Oct 19, 2021
@ghost
Copy link

ghost commented Oct 19, 2021

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

Run Information

Architecture x64
OS alpine 3.12
Baseline 11742903dcc40a55e8688a1c61291459215f8ed0
Compare f40247e8e4276ec4472eaeaac461bb3bc14c2cd0
Diff Diff

Regressions in System.Collections.CtorFromCollection<String>

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio Baseline ETL Compare ETL
ImmutableList - Duration of single invocation 9.61 μs 10.42 μs 1.08 0.05 False

graph
Test Report

Repro

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net6.0 --filter 'System.Collections.CtorFromCollection&lt;String&gt;*'

Payloads

Baseline
Compare

Histogram

System.Collections.CtorFromCollection<String>.ImmutableList(Size: 512)

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

Author: performanceautofiler[bot]
Assignees: -
Labels:

area-System.Collections, arch-x64, area-CodeGen-coreclr, os-alpine, untriaged
Milestone: -

@kunalspathak kunalspathak added tenet-performance Performance related issue tenet-performance-benchmarks Issue from performance benchmark labels Oct 19, 2021
@jakobbotsch jakobbotsch self-assigned this Oct 19, 2021
@jakobbotsch jakobbotsch added this to the 7.0.0 milestone Oct 19, 2021
@ghost ghost removed the untriaged New issue has not been triaged by the area owner label Oct 19, 2021
jakobbotsch added a commit to jakobbotsch/runtime that referenced this issue Oct 21, 2021
@jakobbotsch
Turn off reloc generation for handles
520600a 
Due to dotnet#60712 we cannot unconditionally generate lea for handles, since
the runtime does not expect us to generate ask for reloc hints for
arbitrary constants. In addition, for many Intel CPUs it looks like
rip-relative lea has greater latency than mov with an 8-byte immediate.

Instead of reverting the change I'm just turning it off here, since the
change also unified a couple of functions to simplify the handling.

Fix dotnet#60627
Fix dotnet#60626
@jakobbotsch jakobbotsch mentioned this issue Oct 21, 2021
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Oct 21, 2021
jakobbotsch added a commit that referenced this issue Oct 22, 2021
@jakobbotsch
Turn off reloc generation for handles (#60721)
24864a9 
Due to #60712 we cannot unconditionally generate lea for handles, since
the runtime does not expect us to generate ask for reloc hints for
arbitrary constants. In addition, for many Intel CPUs it looks like
rip-relative lea has greater latency than mov with an 8-byte immediate.

Instead of reverting the change I'm just turning it off here, since the
change also unified a couple of functions to simplify the handling.

Fix #60626
Fix #60627
Fix #60629
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Oct 22, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Nov 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jakobbotsch jakobbotsch

Labels
arch-x64 area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI os-alpine tenet-performance Performance related issue tenet-performance-benchmarks Issue from performance benchmark
Projects
None yet
Milestone
7.0.0
Development

Successfully merging a pull request may close this issue.

Turn off reloc generation for handles jakobbotsch/runtime
3 participants
@eiriktsarpalis @jakobbotsch @kunalspathak