System.Drawing.Tests.PenTests.Ctor_Brush_Width<SolidBrush> test fail

[AlexRadch]

Description

System.Drawing.Tests.PenTests.Ctor_Brush_Width<SolidBrush> test fail on Russian Windows when SolidBrush width < 1 with next logs:

    6)   System.Drawing.Tests.PenTests.Ctor_Brush_Width<SolidBrush>(brush: SolidBrush { Color = Color [Red] }, width: 0, expectedPenType: SolidColor) 
      Duration: 9 ms

      Message: 
Assert.Equal() Failure
Expected: 0
Actual:   1

      Stack Trace: 
PenTests.VerifyPen[T](Pen pen, PenType expectedPenType, Single expectedWidth) line 1378
PenTests.Ctor_Brush_Width[T](T brush, Single width, PenType expectedPenType) line 56

    7)   System.Drawing.Tests.PenTests.Ctor_Brush_Width<SolidBrush>(brush: SolidBrush { Color = Color [Red] }, width: -1, expectedPenType: SolidColor) 
      Duration: < 1 ms

      Message: 
Assert.Equal() Failure
Expected: -1
Actual:   1

      Stack Trace: 
PenTests.VerifyPen[T](Pen pen, PenType expectedPenType, Single expectedWidth) line 1378
PenTests.Ctor_Brush_Width[T](T brush, Single width, PenType expectedPenType) line 56

    9)   System.Drawing.Tests.PenTests.Ctor_Brush_Width<SolidBrush>(brush: SolidBrush { Color = Color [Red] }, width: -∞, expectedPenType: SolidColor) 
      Duration: < 1 ms

      Message: 
Assert.Equal() Failure
Expected: -∞
Actual:   1

      Stack Trace: 
PenTests.VerifyPen[T](Pen pen, PenType expectedPenType, Single expectedWidth) line 1378
PenTests.Ctor_Brush_Width[T](T brush, Single width, PenType expectedPenType) line 56

Reproduction Steps

Run tests on Russian Windows 10.

Expected behavior

Passed tests.

Actual behavior

Failed tests.

Regression?

Are test data correct for all windows?

            yield return new object[] { new SolidBrush(Color.Red), 0, PenType.SolidColor };
            yield return new object[] { new SolidBrush(Color.Red), -1, PenType.SolidColor };
            yield return new object[] { new SolidBrush(Color.Red), float.NegativeInfinity, PenType.SolidColor };

Known Workarounds

No response

Configuration

No response

Other information

No response

[ghost]

Tagging subscribers to this area: @safern, @tarekgh
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Description

System.Drawing.Tests.PenTests.Ctor_Brush_Width test fail on Russian Windows with next logs:

    6)   System.Drawing.Tests.PenTests.Ctor_Brush_Width<SolidBrush>(brush: SolidBrush { Color = Color [Red] }, width: 0, expectedPenType: SolidColor) 
      Duration: 9 ms

      Message: 
Assert.Equal() Failure
Expected: 0
Actual:   1

      Stack Trace: 
PenTests.VerifyPen[T](Pen pen, PenType expectedPenType, Single expectedWidth) line 1378
PenTests.Ctor_Brush_Width[T](T brush, Single width, PenType expectedPenType) line 56

    7)   System.Drawing.Tests.PenTests.Ctor_Brush_Width<SolidBrush>(brush: SolidBrush { Color = Color [Red] }, width: -1, expectedPenType: SolidColor) 
      Duration: < 1 ms

      Message: 
Assert.Equal() Failure
Expected: -1
Actual:   1

      Stack Trace: 
PenTests.VerifyPen[T](Pen pen, PenType expectedPenType, Single expectedWidth) line 1378
PenTests.Ctor_Brush_Width[T](T brush, Single width, PenType expectedPenType) line 56

    9)   System.Drawing.Tests.PenTests.Ctor_Brush_Width<SolidBrush>(brush: SolidBrush { Color = Color [Red] }, width: -∞, expectedPenType: SolidColor) 
      Duration: < 1 ms

      Message: 
Assert.Equal() Failure
Expected: -∞
Actual:   1

      Stack Trace: 
PenTests.VerifyPen[T](Pen pen, PenType expectedPenType, Single expectedWidth) line 1378
PenTests.Ctor_Brush_Width[T](T brush, Single width, PenType expectedPenType) line 56

Reproduction Steps

Run tests on Russian Windows 10.

Expected behavior

Passed tests.

Actual behavior

Failed tests.

Regression?

Are test data correct for all windows?

            yield return new object[] { new SolidBrush(Color.Red), 0, PenType.SolidColor };
            yield return new object[] { new SolidBrush(Color.Red), -1, PenType.SolidColor };
            yield return new object[] { new SolidBrush(Color.Red), float.NegativeInfinity, PenType.SolidColor };

Known Workarounds

No response

Configuration

No response

Other information

No response

Author:	AlexRadch
Assignees:	-
Labels:	area-System.Drawing, untriaged
Milestone:	-

[danmoseley]

We just call

            int status = Gdip.GdipCreatePen2(new HandleRef(brush, brush.NativeBrush),
                width,
                (int)GraphicsUnit.World,
                out pen);

including checking the return code, then read it back

                var width = new float[] { 0 };
                int status = Gdip.GdipGetPenWidth(new HandleRef(this, NativePen), width);

and again throw if it returns other than OK. Seems a Windows issue.

Apparently this is only happening for those invalid width values, and passing for the valid ones. So it seems no big deal. My suggestion is to just disable the invalid ones (Ctor_Brush_Width_TestData) for non English.

[AlexRadch]

My suggestion is to just disable the invalid ones (Ctor_Brush_Width_TestData) for non English.

Do you suggest disabling the invalid ones for non-English for all OS or Windows only?