Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move SuperPMI replay pipeline to "public" #59443

Closed
BruceForstall opened this issue Sep 22, 2021 · 5 comments
Closed

Move SuperPMI replay pipeline to "public" #59443

BruceForstall opened this issue Sep 22, 2021 · 5 comments
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Milestone

Comments

@BruceForstall
Copy link
Member

An Azure DevOps pipeline was created to run a SuperPMI replay across all existing public collections when a JIT change is committed (#52392, #56871). This pipeline was created in the "internal" part of the AzDO instance, so is inaccessible to external contributors, and is not triggerable on GitHub pull requests.

This issue tracks the work to move the pipeline to the "public" instance.

@BruceForstall BruceForstall added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Sep 22, 2021
@BruceForstall BruceForstall added this to the 7.0.0 milestone Sep 22, 2021
@ghost
Copy link

ghost commented Sep 22, 2021

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

An Azure DevOps pipeline was created to run a SuperPMI replay across all existing public collections when a JIT change is committed (#52392, #56871). This pipeline was created in the "internal" part of the AzDO instance, so is inaccessible to external contributors, and is not triggerable on GitHub pull requests.

This issue tracks the work to move the pipeline to the "public" instance.

Author: BruceForstall
Assignees: -
Labels:

area-CodeGen-coreclr

Milestone: 7.0.0

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Sep 22, 2021
@BruceForstall BruceForstall removed the untriaged New issue has not been triaged by the area owner label Sep 22, 2021
@BruceForstall
Copy link
Member Author

@kunalspathak Are there any other work items tracking follow-up work ideas from the superpmi-replay pipeline creation?

@kunalspathak
Copy link
Member

There is no tracking GH issue, but here is what are good to have before we make it public:

  • Since I have introduced superpmi-replay** files, we should rename the existing superpmi-collect related files to superpmi-collect* .
  • Also, today, if there are JITEE changes, superpmi-collect and superpmi-replay pipeline will start simultaneously. Since there is a reason to do the collection after JITEE changes, superpmi-replay should run on the fresh collection. In order for that to happen, superpmi-replay should not run during JITEE changes, but should be triggered by superpmi-collect pipeline using pipeline triggers mechanism.

@BruceForstall
Copy link
Member Author

I think the "coordinate superpmi-collect and superpmi-replay pipelines after a JIT-EE version change" as a "nice to have", but if it's expensive or complicated to implement, it might not be worth the effort, given the (normally) low rate of JIT-EE version changes.

@kunalspathak
Copy link
Member

Done in #60375.

@ghost ghost locked as resolved and limited conversation to collaborators Nov 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

No branches or pull requests

2 participants