-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ALPN processing on Linux can be improved #58299
Comments
Tagging subscribers to this area: @dotnet/ncl, @vcsjones Issue Detailsthis was noticed while working on #57079 runtime/src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/HttpConnectionPool.cs Lines 298 to 300 in 999e412
|
After discussion, there don't seem to be more opportunities for (meaningful) optimizations other than stackalloc'ing the buffer when setting ALPN. |
this was noticed while working on #57079
There are few places when we allocate when we may not need to - particularly converting ALPN list to array.
The list is typically small so we may use stackalloc.
Further more, typical use would probably have only http11 and h2. We can probably special-case this and avoid processing for each connection. HttpClient already does that:
runtime/src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/HttpConnectionPool.cs
Lines 298 to 300 in 999e412
The text was updated successfully, but these errors were encountered: