Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microsoft.Extensions.Http undoc APIs #58131

Closed
carlossanlop opened this issue Aug 25, 2021 · 4 comments
Closed

Microsoft.Extensions.Http undoc APIs #58131

carlossanlop opened this issue Aug 25, 2021 · 4 comments
Labels
area-Extensions-HttpClientFactory documentation Documentation bug or enhancement, does not impact product or test code
Milestone

Comments

@carlossanlop
Copy link
Member

Here is a list of undocumented APIs for @dotnet/ncl belonging to Microsoft.Extensions.Http. It's ok to move these to 7.0 since these APIs seem to exist before 6.0.

If these APIs are already documented in triple slash, you can execute the DocsPortingTool command below to port them to dotnet-api-docs.

If they aren't yet documented, since these namespaces don't yet have triple slash comments as their source of truth, you can either:

  • Get them documented directly in dotnet-api-docs (we will backport them to triple slash later), or
  • Get them documented in triple slash first, then use the command below to port them to dotnet-api-docs.
DocsPortingTool \
    -Direction ToDocs \
    -Docs %REPOS%\dotnet-api-docs\xml \
    -Intellisense %REPOS%\runtime\artifacts\bin\ \
    -IncludedAssemblies Microsoft.Extensions \
    -IncludedNamespaces Microsoft.Extensions.Http \
    -Save true
Microsoft.Extensions.Http
Microsoft.Extensions.Http
N:Microsoft.Extensions.Http
M:Microsoft.Extensions.Http.HttpClientFactoryOptions.#ctor
M:Microsoft.Extensions.Http.HttpMessageHandlerBuilder.#ctor
M:Microsoft.Extensions.Http.HttpMessageHandlerBuilder.CreateHandlerPipeline(System.Net.Http.HttpMessageHandler,System.Collections.Generic.IEnumerable{System.Net.Http.DelegatingHandler})
M:Microsoft.Extensions.Http.IHttpMessageHandlerBuilderFilter.Configure(System.Action{Microsoft.Extensions.Http.HttpMessageHandlerBuilder})
N:Microsoft.Extensions.Http.Logging
M:Microsoft.Extensions.Http.Logging.LoggingHttpMessageHandler.#ctor(Microsoft.Extensions.Logging.ILogger)
M:Microsoft.Extensions.Http.Logging.LoggingHttpMessageHandler.#ctor(Microsoft.Extensions.Logging.ILogger,Microsoft.Extensions.Http.HttpClientFactoryOptions)
T:Microsoft.Extensions.Http.Logging.LoggingHttpMessageHandler
M:Microsoft.Extensions.Http.Logging.LoggingHttpMessageHandler.SendAsync(System.Net.Http.HttpRequestMessage,System.Threading.CancellationToken)
M:Microsoft.Extensions.Http.Logging.LoggingScopeHttpMessageHandler.#ctor(Microsoft.Extensions.Logging.ILogger)
M:Microsoft.Extensions.Http.Logging.LoggingScopeHttpMessageHandler.#ctor(Microsoft.Extensions.Logging.ILogger,Microsoft.Extensions.Http.HttpClientFactoryOptions)
T:Microsoft.Extensions.Http.Logging.LoggingScopeHttpMessageHandler
M:Microsoft.Extensions.Http.Logging.LoggingScopeHttpMessageHandler.SendAsync(System.Net.Http.HttpRequestMessage,System.Threading.CancellationToken)
@carlossanlop carlossanlop added the documentation Documentation bug or enhancement, does not impact product or test code label Aug 25, 2021
@dotnet-issue-labeler dotnet-issue-labeler bot added area-Extensions-HttpClientFactory untriaged New issue has not been triaged by the area owner labels Aug 25, 2021
@ghost
Copy link

ghost commented Aug 25, 2021

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Here is a list of undocumented APIs for @dotnet/ncl belonging to Microsoft.Extensions.Http. It's ok to move these to 7.0 since these APIs seem to exist before 6.0.

If these APIs are already documented in triple slash, you can execute the DocsPortingTool command below to port them to dotnet-api-docs.

If they aren't yet documented, since these namespaces don't yet have triple slash comments as their source of truth, you can either:

  • Get them documented directly in dotnet-api-docs (we will backport them to triple slash later), or
  • Get them documented in triple slash first, then use the command below to port them to dotnet-api-docs.
DocsPortingTool \
    -Direction ToDocs \
    -Docs %REPOS%\dotnet-api-docs\xml \
    -Intellisense %REPOS%\runtime\artifacts\bin\ \
    -IncludedAssemblies Microsoft.Extensions \
    -IncludedNamespaces Microsoft.Extensions.Http \
    -Save true
Microsoft.Extensions.Http
Microsoft.Extensions.Http
N:Microsoft.Extensions.Http
M:Microsoft.Extensions.Http.HttpClientFactoryOptions.#ctor
M:Microsoft.Extensions.Http.HttpMessageHandlerBuilder.#ctor
M:Microsoft.Extensions.Http.HttpMessageHandlerBuilder.CreateHandlerPipeline(System.Net.Http.HttpMessageHandler,System.Collections.Generic.IEnumerable{System.Net.Http.DelegatingHandler})
M:Microsoft.Extensions.Http.IHttpMessageHandlerBuilderFilter.Configure(System.Action{Microsoft.Extensions.Http.HttpMessageHandlerBuilder})
N:Microsoft.Extensions.Http.Logging
M:Microsoft.Extensions.Http.Logging.LoggingHttpMessageHandler.#ctor(Microsoft.Extensions.Logging.ILogger)
M:Microsoft.Extensions.Http.Logging.LoggingHttpMessageHandler.#ctor(Microsoft.Extensions.Logging.ILogger,Microsoft.Extensions.Http.HttpClientFactoryOptions)
T:Microsoft.Extensions.Http.Logging.LoggingHttpMessageHandler
M:Microsoft.Extensions.Http.Logging.LoggingHttpMessageHandler.SendAsync(System.Net.Http.HttpRequestMessage,System.Threading.CancellationToken)
M:Microsoft.Extensions.Http.Logging.LoggingScopeHttpMessageHandler.#ctor(Microsoft.Extensions.Logging.ILogger)
M:Microsoft.Extensions.Http.Logging.LoggingScopeHttpMessageHandler.#ctor(Microsoft.Extensions.Logging.ILogger,Microsoft.Extensions.Http.HttpClientFactoryOptions)
T:Microsoft.Extensions.Http.Logging.LoggingScopeHttpMessageHandler
M:Microsoft.Extensions.Http.Logging.LoggingScopeHttpMessageHandler.SendAsync(System.Net.Http.HttpRequestMessage,System.Threading.CancellationToken)
Author: carlossanlop
Assignees: -
Labels:

documentation, untriaged, area-Extensions-HttpClientFactory

Milestone: -

@CarnaViire
Copy link
Member

Seems like a dupe of #43916? @carlossanlop

@carlossanlop
Copy link
Member Author

carlossanlop commented Aug 31, 2021

Yes, you're correct, @CarnaViire . These are not 6.0 debt, these are older, hence why the older issue is there.
I'm closing this issue as duplicate, just please double check if the list in this issue's description contains additional undoc APIs that were not mentioned in the old issue (the old issue was opened some time ago).

@carlossanlop
Copy link
Member Author

Duplicate of #43916

@carlossanlop carlossanlop marked this as a duplicate of #43916 Aug 31, 2021
@karelz karelz added this to the 7.0.0 milestone Sep 8, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Oct 9, 2021
@karelz karelz removed the untriaged New issue has not been triaged by the area owner label Oct 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Extensions-HttpClientFactory documentation Documentation bug or enhancement, does not impact product or test code
Projects
None yet
Development

No branches or pull requests

3 participants