Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model the macOS/OSX alias through the guard attributes #57225

Open
3 tasks
buyaa-n opened this issue Aug 11, 2021 · 0 comments
Open
3 tasks

Model the macOS/OSX alias through the guard attributes #57225

buyaa-n opened this issue Aug 11, 2021 · 0 comments
Milestone

Comments

@buyaa-n
Copy link
Contributor

buyaa-n commented Aug 11, 2021

In 6.0 we have updated the PCA analyzer to use the guard attributes on the OperatingSystem.IsXYZ methods in order to communicate the platform compat relationship between platforms, this approach can be used for macOS/OSX instead of hard coding the relation. This could include the following steps:

  1. Add SupportedOSPlatformGuard("OSX") to the OperatingSystem.IsMacOS() to express the relation OSX is MacOS
  2. Figure how to add the MacOS is OSX relation
  3. Figure out how to handle the backward compatibility and remove the hardcoded macOS/OSX relation in the analyzer

Originally posted by @jeffhandley in #53084 (comment)

@dotnet-issue-labeler dotnet-issue-labeler bot added area-Meta untriaged New issue has not been triaged by the area owner labels Aug 11, 2021
@buyaa-n buyaa-n added this to the 7.0.0 milestone Aug 11, 2021
@buyaa-n buyaa-n removed the untriaged New issue has not been triaged by the area owner label Aug 11, 2021
@danmoseley danmoseley modified the milestones: 7.0.0, Future Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

2 participants