Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RVAOrderingTest fails under composite R2R testing #55966

Open
davidwrighton opened this issue Jul 19, 2021 · 0 comments
Open

RVAOrderingTest fails under composite R2R testing #55966

davidwrighton opened this issue Jul 19, 2021 · 0 comments

Comments

@davidwrighton
Copy link
Member

Description

src/tests/Directed/rvastatics/RVAOrderingTest.ilproj fails when compiled in R2R composite mode.

The issue is that the compiler copies only the RVA fields needed by the actual used code into the image using the RVA static fields in their initial location. This has an impact on the correctness of C++/CLI applications; however, as C++/CLI binaries are not supported by Crossgen2 in .NET 6, this is not a significant consequence. A proposed fix is available via pr #55861 but as it is a somewhat risky fix for a scenario unsupported in .NET 6, I did not push the fix into the product. In addition, testing for all possible scenarios via hand-written IL, cannot be done at this time, as ilasm does not support productin non-IL Only binaries, and the current IL sdk integration does not support producing architecture specific binaries.

Regression?

No

@dotnet-issue-labeler dotnet-issue-labeler bot added area-crossgen2-coreclr untriaged New issue has not been triaged by the area owner labels Jul 19, 2021
@davidwrighton davidwrighton added this to the 7.0.0 milestone Jul 19, 2021
@jeffschwMSFT jeffschwMSFT removed the untriaged New issue has not been triaged by the area owner label Jul 21, 2021
@davidwrighton davidwrighton modified the milestones: 7.0.0, 8.0.0 Jul 6, 2022
@trylek trylek mentioned this issue May 3, 2023
46 tasks
@mangod9 mangod9 modified the milestones: 8.0.0, Future Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants