Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Net5CompatFileStreamStrategy in .NET 7 early previews #55196

Closed
Tracked by #64596
adamsitnik opened this issue Jul 6, 2021 · 2 comments · Fixed by #57735
Closed
Tracked by #64596

Remove Net5CompatFileStreamStrategy in .NET 7 early previews #55196

adamsitnik opened this issue Jul 6, 2021 · 2 comments · Fixed by #57735
Labels
area-System.IO breaking-change Issue or PR that represents a breaking API or functional change over a prerelease.
Milestone
7.0.0

Comments

@adamsitnik
Copy link
Member

adamsitnik commented Jul 6, 2021 •
edited
Loading

For .NET 6, we have made FileStream much faster and more reliable, thanks to an almost entire re-write. The rewrite has introduced two breaking changes. We assumed that it might have introduced bugs as well. Because of that, .NET 6 shipped with a built-in FileStream .NET 5 compatibility mode which users could request by using an app compat switch or an environment variable.

Our assumptions were right, the rewrite has introduced some edge-case bugs. All of the reported issues are already fixed:

Since currently there are no known FileStream bugs introduced in .NET 6, the .NET 5 FileStream compatibility mode was removed. This change is included in .NET 7 preview 1.

Please let us know if there is any scenario that can’t be implemented in .NET 7 without using the .NET 5 compatibility mode.
@adamsitnik adamsitnik added this to the 7.0.0 milestone Jul 6, 2021
@adamsitnik adamsitnik self-assigned this Jul 6, 2021
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Jul 6, 2021
@ghost
Copy link

ghost commented Jul 6, 2021

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

Issue Details

cc @stephentoub

Author: adamsitnik
Assignees: adamsitnik
Labels:

area-System.IO
Milestone: 7.0.0

@adamsitnik adamsitnik removed the untriaged New issue has not been triaged by the area owner label Jul 6, 2021
@stephentoub
Copy link
Member

We might want to wait a little while, in order to make it easier to port back to release/6.0 any straggling issues.

@adamsitnik adamsitnik mentioned this issue Jul 22, 2021
Closed
@jeffhandley jeffhandley changed the title Remove Net5CompatFileStreamStrategy as soon as we snap for .NET 7 Remove Net5CompatFileStreamStrategy in .NET 7 early previews Jul 30, 2021
@teo-tsirpanis teo-tsirpanis mentioned this issue Aug 19, 2021
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Aug 19, 2021
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Oct 9, 2021
@adamsitnik adamsitnik removed their assignment Oct 11, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Nov 10, 2021
@adamsitnik adamsitnik added the breaking-change Issue or PR that represents a breaking API or functional change over a prerelease. label Jan 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-System.IO breaking-change Issue or PR that represents a breaking API or functional change over a prerelease.
Projects
None yet
Milestone
7.0.0
Development

Successfully merging a pull request may close this issue.

Remove Net5CompatFileStreamStrategy. teo-tsirpanis/dotnet-runtime
2 participants
@stephentoub @adamsitnik