Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QUIC: Rename S.N.Quic --> S.N.Private.Quic #54720

Closed
ManickaP opened this issue Jun 25, 2021 · 7 comments
Closed

QUIC: Rename S.N.Quic --> S.N.Private.Quic #54720

ManickaP opened this issue Jun 25, 2021 · 7 comments
Assignees
@ManickaP
Labels
area-System.Net.Quic enhancement Product code improvement that does NOT require public API changes/additions
Milestone
6.0.0

Comments

@ManickaP
Copy link
Member

Follow up for #54534

The naming scheme for our internal libraries contains Private to properly communicate the intent. I intentionally skipped this step in the #54610 to cause the least churn possible while very active development is ongoing and also to get the change in ASAP.

We should decide whether we want to do the rename and if so when.

This issue is irrelevant post 6.0, since we plan to properly expose the APIs for 7.0.
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Jun 25, 2021
@ghost
Copy link

ghost commented Jun 25, 2021

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Follow up for #54534

The naming scheme for our internal libraries contains Private to properly communicate the intent. I intentionally skipped this step in the #54610 to cause the least churn possible while very active development is ongoing and also to get the change in ASAP.

We should decide whether we want to do the rename and if so when.

This issue is irrelevant post 6.0, since we plan to properly expose the APIs for 7.0.

Author: ManickaP
Assignees: -
Labels:

area-System.Net.Quic, untriaged
Milestone: -

@ManickaP
Copy link
Member Author

@karelz this needs triage with our QUIC team.

@karelz
Copy link
Member

karelz commented Jun 25, 2021

I think we should do it for .NET 6. Let's discuss on Tue in QUIC meeting.

@karelz karelz added enhancement Product code improvement that does NOT require public API changes/additions and removed untriaged New issue has not been triaged by the area owner labels Jul 1, 2021
@karelz karelz added this to the 6.0.0 milestone Jul 1, 2021
@karelz
Copy link
Member

karelz commented Jul 1, 2021

Triage: We should hide it behind the PreviewFeatureAttribute

@ManickaP
Copy link
Member Author

ManickaP commented Jul 1, 2021

Related to #55024

@ManickaP
Copy link
Member Author

ManickaP commented Jul 8, 2021

Closing in favor of #55024

@ManickaP ManickaP closed this as completed Jul 8, 2021
@ManickaP ManickaP mentioned this issue Jul 8, 2021
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Aug 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ManickaP ManickaP

Labels
area-System.Net.Quic enhancement Product code improvement that does NOT require public API changes/additions
Projects
None yet
Milestone
6.0.0
Development

No branches or pull requests
2 participants
@karelz @ManickaP