Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Override more methods in PipeReaderStream and PipeWriterStream #53692

Closed
halter73 opened this issue Jun 3, 2021 · 0 comments · Fixed by #55086
Closed

Override more methods in PipeReaderStream and PipeWriterStream #53692

halter73 opened this issue Jun 3, 2021 · 0 comments · Fixed by #55086
Labels
area-System.IO.Pipelines help wanted [up-for-grabs] Good issue for external contributors tenet-performance Performance related issue
Milestone
Future

Comments

@halter73
Copy link
Member

halter73 commented Jun 3, 2021

During discussion over #33788, I pointed out that PipeReader/WriterStream don't implement Stream.ReadByte/WriteByte. There's a bunch of other methods to we could consider overriding. Most of the sync methods fall back to the default implementation.

However, the sync methods generally end up being sync-over-async when wrapping a DefaultPipeReader/Writer, so maybe it's not worth further optimizing these.
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Jun 3, 2021
@BrennanConroy BrennanConroy added the help wanted [up-for-grabs] Good issue for external contributors label Jun 4, 2021
@BrennanConroy BrennanConroy added this to the Future milestone Jun 4, 2021
@BrennanConroy BrennanConroy removed the untriaged New issue has not been triaged by the area owner label Jun 4, 2021
@stephentoub stephentoub mentioned this issue Jul 2, 2021
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Jul 2, 2021
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Jul 8, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Aug 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-System.IO.Pipelines help wanted [up-for-grabs] Good issue for external contributors tenet-performance Performance related issue
Projects
None yet
Milestone
Future
Development

Successfully merging a pull request may close this issue.

Override Read(Span)/ReadByte on PipeReaderStream stephentoub/runtime
2 participants
@halter73 @BrennanConroy