-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JsonSerializer trimming tests should be re-written to use the source generator #53437
Comments
Tagging subscribers to this area: @eiriktsarpalis, @layomia Issue DetailsThe JsonSerializer is not trim-compatible when not using the JSON source generator (see #51886). However, we have a bunch of "trimming tests" that used it in a trimmed app, but only for one level of objects (like just one I am removing a bunch of these tests while working on #52268 and #53256 because they no longer pass after these issues are resolved. However, supporting these scenarios in a trimmed app is important. The trim-compatible way to use JsonSerializer is to use the JSON source generator, and pass in the generated We should re-do these trimming tests to use the JSON source generator and add them back. However, this can't happen until the JSON source generator supports all the collection types that the JsonSerializer supports (#53393). This issue is to track bringing all these trimming tests using the JSON source generator. cc @layomia
|
Test enhancement, moving to 7.0.0. |
I believe this has been superseded by recent work. |
The trimming tests are not using the source generator. |
The JsonSerializer is not trim-compatible when not using the JSON source generator (see #51886). However, we have a bunch of "trimming tests" that used it in a trimmed app, but only for one level of objects (like just one
Hashtable
orQueue<T>
).I am removing a bunch of these tests while working on #52268 and #53256 because they no longer pass after these issues are resolved.
However, supporting these scenarios in a trimmed app is important. The trim-compatible way to use JsonSerializer is to use the JSON source generator, and pass in the generated
JsonTypeInfo<T>
to the JsonSerializer.We should re-do these trimming tests to use the JSON source generator and add them back. However, this can't happen until the JSON source generator supports all the collection types that the JsonSerializer supports (#53393).
This issue is to track bringing all these trimming tests using the JSON source generator.
cc @layomia
The text was updated successfully, but these errors were encountered: