Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable AddressSanitizer on Debug and Checked builds for both MSVC and Clang #52131

Closed
jkoritzinsky opened this issue Apr 30, 2021 · 2 comments
Closed
Labels
area-Infrastructure tenet-reliability Reliability/stability related issue (stress, load problems, etc.)
Milestone

Comments

@jkoritzinsky
Copy link
Member

AddressSanitizer is a tool that helps with common bugs like use-out-of-scope, buffer-overflow, use-after-free, etc. It is supported on GCC, Clang, and newer versions of MSVC.

Today, we use Run-Time Checks on MSVC to validate some of these scenarios, but we don't run any equivalent on non-MSVC builds. We have some infrastructure for running AddressSanitizer on Clang builds, but we've never enabled it for our builds (some partners have enabled it for theirs at various times).

By enabling AddressSanitizer for both our MSVC and Clang builds, we would ensure that we validate our code against common classes of bugs in C and C++.

@jkoritzinsky jkoritzinsky added tenet-reliability Reliability/stability related issue (stress, load problems, etc.) area-Infrastructure labels Apr 30, 2021
@ghost
Copy link

ghost commented Apr 30, 2021

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

AddressSanitizer is a tool that helps with common bugs like use-out-of-scope, buffer-overflow, use-after-free, etc. It is supported on GCC, Clang, and newer versions of MSVC.

Today, we use Run-Time Checks on MSVC to validate some of these scenarios, but we don't run any equivalent on non-MSVC builds. We have some infrastructure for running AddressSanitizer on Clang builds, but we've never enabled it for our builds (some partners have enabled it for theirs at various times).

By enabling AddressSanitizer for both our MSVC and Clang builds, we would ensure that we validate our code against common classes of bugs in C and C++.

Author: jkoritzinsky
Assignees: -
Labels:

area-Infrastructure, tenet-reliability

Milestone: -

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Apr 30, 2021
@ViktorHofer ViktorHofer removed the untriaged New issue has not been triaged by the area owner label May 5, 2021
@ViktorHofer ViktorHofer added this to the Future milestone May 5, 2021
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Jun 22, 2021
@ghost ghost added in-pr There is an active PR which will close this issue when it is merged and removed in-pr There is an active PR which will close this issue when it is merged labels Aug 29, 2021
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Jul 22, 2022
@jkoritzinsky
Copy link
Member Author

We've enabled ASAN though a new command line option instead of per-config.

@github-actions github-actions bot locked and limited conversation to collaborators Sep 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Infrastructure tenet-reliability Reliability/stability related issue (stress, load problems, etc.)
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants