Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consolidate _handshakeBuffer and _internalBuffer inside SslStream #52037

Closed
wfurt opened this issue Apr 29, 2021 · 1 comment · Fixed by #64747
Closed

consolidate _handshakeBuffer and _internalBuffer inside SslStream #52037

wfurt opened this issue Apr 29, 2021 · 1 comment · Fixed by #64747
Labels
area-System.Net.Security enhancement Product code improvement that does NOT require public API changes/additions
Milestone
7.0.0

Comments

@wfurt
Copy link
Member

wfurt commented Apr 29, 2021

related to #49346
related to #49000

both buffers are currently rented from ArrayBuufer. Aside from code duplication we need to copy leftovers when we transition from handshake to read, read to handshake during TLS 1.3 processing or during renegotiation/late cert retrieval.

using single buffer would simplify internal logic and reduce code.
@wfurt wfurt added enhancement Product code improvement that does NOT require public API changes/additions area-System.Net.Security labels Apr 29, 2021
@ghost
Copy link

ghost commented Apr 29, 2021

Tagging subscribers to this area: @dotnet/ncl, @vcsjones
See info in area-owners.md if you want to be subscribed.

Issue Details

related to #49346
related to #49000

both buffers are currently rented from ArrayBuufer. Aside from code duplication we need to copy leftovers when we transition from handshake to read, read to handshake during TLS 1.3 processing or during renegotiation/late cert retrieval.

using single buffer would simplify internal logic and reduce code.

Author: wfurt
Assignees: -
Labels:

area-System.Net.Security, enhancement
Milestone: -

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Apr 29, 2021
@karelz karelz added this to the Future milestone Apr 29, 2021
@karelz karelz removed the untriaged New issue has not been triaged by the area owner label Apr 29, 2021
@wfurt wfurt self-assigned this Dec 31, 2021
@wfurt wfurt modified the milestones: Future, 7.0.0 Dec 31, 2021
@wfurt wfurt mentioned this issue Dec 31, 2021
Merged
@wfurt wfurt mentioned this issue Jan 13, 2022
Closed
@rzikm rzikm assigned rzikm and unassigned wfurt Feb 2, 2022
@rzikm rzikm mentioned this issue Feb 3, 2022
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Feb 3, 2022
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Feb 9, 2022
@rzikm rzikm removed their assignment Feb 14, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Mar 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-System.Net.Security enhancement Product code improvement that does NOT require public API changes/additions
Projects
None yet
Milestone
7.0.0
Development

Successfully merging a pull request may close this issue.

Consolidate _handshakeBuffer and _internalBuffer in SslStream rzikm/dotnet-runtime
3 participants
@karelz @wfurt @rzikm