Eager options validation only validates the last named option

[aelij]

Description

Repro:

using System;
using System.Threading.Tasks;
using Microsoft.Extensions.Options;
using Microsoft.Extensions.Hosting;
using Microsoft.Extensions.DependencyInjection;
using System.ComponentModel.DataAnnotations;

namespace Test
{
    class Program
    {
        static Task Main() => Host.CreateDefaultBuilder().ConfigureServices(s => 
            s.AddOptions<M>().ValidateOnStart().Validate(m => m.A < 0, "A should be negative").Services
            .AddOptions<M>("y").ValidateOnStart().Validate(m => m.A > 0, "A should be positive")).RunConsoleAsync();
    }

    class M
    {
        public int A { get; set; }
        [Required]
        public string S { get; set; }
    }
}

Expected:
AggregateException with both "A should be negative" and "A should be positive" exceptions

Actual:
Only the last validation runs

Unhandled exception. Microsoft.Extensions.Options.OptionsValidationException: A should be positive
   at Microsoft.Extensions.Options.OptionsFactory`1.Create(String name)
   at Microsoft.Extensions.Options.OptionsMonitor`1.<>c__DisplayClass10_0.<Get>b__0()
   at System.Lazy`1.ViaFactory(LazyThreadSafetyMode mode)
   at System.Lazy`1.ExecutionAndPublication(LazyHelper executionAndPublication, Boolean useDefaultConstructor)
   at System.Lazy`1.CreateValue()
   at System.Lazy`1.get_Value()
   at Microsoft.Extensions.Options.OptionsCache`1.GetOrAdd(String name, Func`1 createOptions)
   at Microsoft.Extensions.Options.OptionsMonitor`1.Get(String name)
   at Microsoft.Extensions.DependencyInjection.OptionsBuilderExtensions.<>c__DisplayClass0_1`1.<ValidateOnStart>b__1()
   at Microsoft.Extensions.DependencyInjection.ValidationHostedService.StartAsync(CancellationToken cancellationToken)

I think the dictionary that stores the validation actions should have a tuple key:

runtime/src/libraries/Microsoft.Extensions.Hosting/src/OptionsBuilderExtensions.cs

Line 34 in 5d0817a

vo.Validators[typeof(TOptions)] = () => options.Get(optionsBuilder.Name);

Should be something like:

vo.Validators[(typeof(TOptions), optionsBuilder.Name)] = () => options.Get(optionsBuilder.Name);

Configuration

6.0.100-preview.3.21202.5 / Linux (WSL)

[ghost]

Tagging subscribers to this area: @maryamariyan
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Description

Repro:

using System;
using System.Threading.Tasks;
using Microsoft.Extensions.Options;
using Microsoft.Extensions.Hosting;
using Microsoft.Extensions.DependencyInjection;
using System.ComponentModel.DataAnnotations;

namespace Test
{
    class Program
    {
        static Task Main() => Host.CreateDefaultBuilder().ConfigureServices(s => 
            s.AddOptions<M>().ValidateOnStart().Validate(m => m.A < 0, "A should be negative").Services
            .AddOptions<M>("y").ValidateOnStart().Validate(m => m.A > 0, "A should be positive")).RunConsoleAsync();
    }

    class M
    {
        public int A { get; set; }
        [Required]
        public string S { get; set; }
    }
}

Expected:
AggregateException with both "A should be negative" and "A should be positive" exceptions

Actual:
Only the last validation runs

Unhandled exception. Microsoft.Extensions.Options.OptionsValidationException: A should be positive
   at Microsoft.Extensions.Options.OptionsFactory`1.Create(String name)
   at Microsoft.Extensions.Options.OptionsMonitor`1.<>c__DisplayClass10_0.<Get>b__0()
   at System.Lazy`1.ViaFactory(LazyThreadSafetyMode mode)
   at System.Lazy`1.ExecutionAndPublication(LazyHelper executionAndPublication, Boolean useDefaultConstructor)
   at System.Lazy`1.CreateValue()
   at System.Lazy`1.get_Value()
   at Microsoft.Extensions.Options.OptionsCache`1.GetOrAdd(String name, Func`1 createOptions)
   at Microsoft.Extensions.Options.OptionsMonitor`1.Get(String name)
   at Microsoft.Extensions.DependencyInjection.OptionsBuilderExtensions.<>c__DisplayClass0_1`1.<ValidateOnStart>b__1()
   at Microsoft.Extensions.DependencyInjection.ValidationHostedService.StartAsync(CancellationToken cancellationToken)

I think the dictionary that stores the validation actions should have a tuple key:

runtime/src/libraries/Microsoft.Extensions.Hosting/src/OptionsBuilderExtensions.cs

Line 34 in 5d0817a

vo.Validators[typeof(TOptions)] = () => options.Get(optionsBuilder.Name);

Should be something like:

vo.Validators[(typeof(TOptions), optionsBuilder.Name)] = () => options.Get(optionsBuilder.Name);

Configuration

6.0.100-preview.3.21202.5 / Linux (WSL)

Author:	aelij
Assignees:	-
Labels:	area-Extensions-Options, untriaged
Milestone:	-

[davidfowl]

Yes that looks right.

[xakep139]

@davidfowl, could you please clarify? Current behavior or proposed one looks right?

[davidfowl]

Proposed