Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mono] MonoAOTCompiler task does not output shared object file extension (.dylib/.so/etc.) #49179

Closed
naricc opened this issue Mar 4, 2021 · 5 comments
Assignees
Milestone

Comments

@naricc
Copy link
Contributor

naricc commented Mar 4, 2021

When AOTing use the MonoAOTCompiler task, the aot object files will have either a dll.o, dll-llvm.o, or a .s extension, depending on the OutputType parameter. However, on desktop these are actually shared object files and should have the appropriate extension (.dylib or .so, depending on the platform), or else the runtime will not find and run the AOT'd code.

My proposal is to add another value the ObjectType enum, maybe "Shared", to control this.

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Mar 4, 2021
@naricc naricc changed the title [Mono] MonoAOTCompiler task will not output shared object file extension (.dylib/.so/etc.) on Desktop [Mono] MonoAOTCompiler task does not output shared object file extension (.dylib/.so/etc.) on Desktop Mar 4, 2021
@SamMonoRT SamMonoRT removed the untriaged New issue has not been triaged by the area owner label Jun 23, 2021
@SamMonoRT SamMonoRT added this to the 6.0.0 milestone Jun 23, 2021
@SamMonoRT
Copy link
Member

@steveisok @directhex - Many changes related to aot object files went in over the last month. Does any of those address this issue and do we really need this for .NET6 ?

@steveisok
Copy link
Member

steveisok commented Jun 23, 2021

We do need this for net6. Android in particular has asked and is something @akoeplinger has been working on.

I would expect a side benefit for it to work on desktop.

@SamMonoRT
Copy link
Member

Assigning to @akoeplinger for easy tracking

@steveisok steveisok changed the title [Mono] MonoAOTCompiler task does not output shared object file extension (.dylib/.so/etc.) on Desktop [Mono] MonoAOTCompiler task does not output shared object file extension (.dylib/.so/etc.) Jun 29, 2021
@ghost
Copy link

ghost commented Jun 29, 2021

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

When AOTing use the MonoAOTCompiler task, the aot object files will have either a dll.o, dll-llvm.o, or a .s extension, depending on the OutputType parameter. However, on desktop these are actually shared object files and should have the appropriate extension (.dylib or .so, depending on the platform), or else the runtime will not find and run the AOT'd code.

My proposal is to add another value the ObjectType enum, maybe "Shared", to control this.

Author: naricc
Assignees: akoeplinger
Labels:

area-Codegen-AOT-mono, area-Infrastructure-mono

Milestone: 6.0.0

@steveisok
Copy link
Member

Fixed by #55753

@ghost ghost locked as resolved and limited conversation to collaborators Aug 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants