Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests fail with System.BadImageFormatException #4852

Open
richardlford opened this issue Dec 21, 2015 · 7 comments · Fixed by dotnet/coreclr#1269
Open

Tests fail with System.BadImageFormatException #4852

richardlford opened this issue Dec 21, 2015 · 7 comments · Fixed by dotnet/coreclr#1269
Assignees
@kunalspathak
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI good first issue Issue should be easy to implement, good for first-time contributors help wanted [up-for-grabs] Good issue for external contributors in-pr There is an active PR which will close this issue when it is merged test-bug Problem in test source code (most likely)
Milestone
10.0.0

Comments

@richardlford
Copy link
Contributor

richardlford commented Dec 21, 2015 •
edited by BruceForstall
Loading

The following tests fail with a mesage like this on a debug win64 test job:

Unhandled Exception: System.BadImageFormatException: 
Could not load file or assembly '<testname>.exe' or one of its dependencies.
An attempt was made to load a program with an incorrect format.

The failing tests are:

JIT\Directed\tls\mutualrecurthd-tls\mutualrecurthd-tls.cmd
JIT\Directed\tls\test-tls\test-tls.cmd
JIT\Regression\CLR-x86-EJIT\v1-m10\b07847\b07847\b07847.cmd
JIT\Regression\CLR-x86-JIT\V1.2-M01\b03689\b03689\b03689.cmd

category:correctness
theme:testing
skill-level:beginner
cost:medium
impact:small
@sivarv
Copy link
Member

sivarv commented Jan 5, 2016

Please check whether TLS statics are supported by CoreCLR.

@LLITCHEV
Copy link
Contributor

LLITCHEV commented Jan 5, 2016

@richardlford
The .data tls FieldData = XXXXXX construct is not supported on non-Windows platforms. It is really OS specific and there is no anything like that available on the non Windows platforms.
These tests are expected to fail on non-Windows platforms. Please move them to the tests/testsUnsupportedOutsideWindows.txt file and close the issue.

@sivarv sivarv assigned richardlford and unassigned LLITCHEV Jan 6, 2016
@RussKeldorph
Copy link
Contributor

RussKeldorph commented May 11, 2016 •
edited
Loading

TLS statics not supported by .NET Core. BadImageFormatException is expected on all platforms. We should replace these tests with a single test that verifies the exception is raised.

@BruceForstall
Copy link
Member

@RussKeldorph Do we need to keep this issue open?

@RussKeldorph
Copy link
Contributor

@BruceForstall If my last comment is no longer actionable or relevant, sure, close it. Otherwise, I'd rather keep it open to track the gap in testing.

@RussKeldorph RussKeldorph removed their assignment Jul 8, 2018
@msftgits msftgits transferred this issue from dotnet/coreclr Jan 30, 2020
@msftgits msftgits added this to the Future milestone Jan 30, 2020
@marcusturewicz
Copy link
Contributor

These files no longer exist so can this issue be closed?

@BruceForstall
Copy link
Member

BruceForstall commented May 5, 2020 •
edited
Loading

These tests still all exist in the test tree (but the tests are not built).

@BruceForstall BruceForstall added the JitUntriaged CLR JIT issues needing additional triage label Oct 28, 2020
@SingleAccretion SingleAccretion mentioned this issue Nov 29, 2021
Closed
@ghost ghost added in-pr There is an active PR which will close this issue when it is merged and removed in-pr There is an active PR which will close this issue when it is merged labels Nov 29, 2021
@TIHan TIHan removed the JitUntriaged CLR JIT issues needing additional triage label Oct 31, 2022
@Woodpile37 Woodpile37 mentioned this issue Mar 21, 2023
Merged
@snyk-bot snyk-bot mentioned this issue Mar 25, 2023
Merged
hootanht added a commit to hootanht/runtime that referenced this issue Sep 1, 2024
@hootanht
Move TLS tests to unsupported list
8212509 
Fixes dotnet#4852

Move tests that fail with `System.BadImageFormatException` to `tests/testsUnsupportedOutsideWindows.txt`.

* Add `src/tests/JIT/Directed/tls/mutualrecurthd-tls.ilproj` to the list.
* Add `src/tests/JIT/Directed/tls/test-tls.ilproj` to the list.
* Add `src/tests/JIT/Regression/CLR-x86-EJIT/v1-m10/b07847/b07847.ilproj` to the list.
@hootanht hootanht mentioned this issue Sep 1, 2024
Closed
@dotnet-policy-service dotnet-policy-service bot added the in-pr There is an active PR which will close this issue when it is merged label Sep 1, 2024
@JulieLeeMSFT JulieLeeMSFT modified the milestones: Future, 10.0.0 Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kunalspathak kunalspathak

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI good first issue Issue should be easy to implement, good for first-time contributors help wanted [up-for-grabs] Good issue for external contributors in-pr There is an active PR which will close this issue when it is merged test-bug Problem in test source code (most likely)
Projects
None yet
Milestone
10.0.0
10 participants
@TIHan @richardlford @msftgits @LLITCHEV @BruceForstall @sivarv @kunalspathak @RussKeldorph @marcusturewicz @JulieLeeMSFT