Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[browser][MT] System.Threading.Tasks.Task.SpinThenBlockingWait(...) uses non supported API #44622

Closed
buyaa-n opened this issue Nov 13, 2020 · 5 comments · Fixed by #99833
Closed
Assignees
Labels
arch-wasm WebAssembly architecture area-System.Threading.Tasks os-browser Browser variant of arch-wasm
Milestone

Comments

@buyaa-n
Copy link
Contributor

buyaa-n commented Nov 13, 2020

Browser compat: System.Threading.Tasks.Task.SpinThenBlockingWait(...) references ManualResetEventSlim.Wait(..) not supported on browser

we need browser-specific implementation. Please create an issue and link if from here. I'm curious how this works today, I guess we are lucky and hit SpinWait all the time

@lewing

Originally posted by @marek-safar in #43363 (comment)

@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added area-System.Threading untriaged New issue has not been triaged by the area owner labels Nov 13, 2020
@buyaa-n buyaa-n added arch-wasm WebAssembly architecture and removed untriaged New issue has not been triaged by the area owner labels Nov 13, 2020
@ghost
Copy link

ghost commented Nov 13, 2020

Tagging subscribers to this area: @tarekgh
See info in area-owners.md if you want to be subscribed.


Issue meta data
Issue content:
Browser compat: System.Threading.Tasks.Task.SpinThenBlockingWait(...) references `ManualResetEventSlim.Wait(..)` not supported on browser

we need browser-specific implementation. Please create an issue and link if from here. I'm curious how this works today, I guess we are lucky and hit SpinWait all the time

@lewing

Originally posted by @marek-safar in #43363 (comment)

</td>
Issue author: buyaa-n
Assignees: -
Labels:
`arch-wasm`, `area-System.Threading.Tasks`

</td>
Milestone: -

@marek-safar marek-safar added this to the 6.0.0 milestone Nov 13, 2020
@lewing lewing modified the milestones: 6.0.0, 7.0.0 Aug 17, 2021
@ilonatommy
Copy link
Member

Where are we with working on this issue @kg? #44543 and #44544 sound like the same problem, so I will pin them here because fix might be similar.

@kg
Copy link
Member

kg commented Jun 13, 2022

We haven't made much progress on this, I've been working on GC crashes.

@lewing lewing modified the milestones: 7.0.0, 8.0.0 Jul 25, 2022
@lewing lewing modified the milestones: 8.0.0, 7.0.x, 9.0.0 Jul 24, 2023
@pavelsavara pavelsavara added the os-browser Browser variant of arch-wasm label Feb 3, 2024
@pavelsavara pavelsavara self-assigned this Feb 3, 2024
@pavelsavara
Copy link
Member

@radekdoulik this is related to .Wait APIs

@pavelsavara pavelsavara changed the title Browser compat: System.Threading.Tasks.Task.SpinThenBlockingWait(...) uses non supported API [browser][MT] System.Threading.Tasks.Task.SpinThenBlockingWait(...) uses non supported API Feb 3, 2024
@pavelsavara pavelsavara assigned radekdoulik and unassigned kg Feb 3, 2024
@radekdoulik
Copy link
Member

I think the ManualResetEventSlim.Wait is now supported in the MT version, #96215 fixed that.

@github-actions github-actions bot locked and limited conversation to collaborators May 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-System.Threading.Tasks os-browser Browser variant of arch-wasm
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants