-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Future of System.IO.Pipes.AccessControl Package. #44600
Comments
Unless we start producing targeting packs for previous .NETCoreApp versions I assume the latter option wouldn't work with source build. I believe we don't yet build anything else than |
yeah sourcebuild was the reason @ericstj suggested to not do this, but we should expore some optons here to avoid harvesting |
Yeah I agree with that we shouldn't use harvesting here as it would suggest to use it as a fallback when an asset isn't buildable anymore. |
I recently added these APIs to System.IO.Pipes.AccessControl for 5.0: runtime/src/libraries/System.IO.Pipes.AccessControl/ref/System.IO.Pipes.AccessControl.cs Lines 69 to 77 in 6072e4d
Does that answer the question, @Anipik ? |
@carlossanlop to rephrase the question, do we expect the package to be updated again in this release cycle? |
To rephrase this, do we expect new APIs? Cause if there is a bug fix we can always do it in the release/5.0 branch, right? |
Caution: 5.0 isn't LTS. Bugfixes could only be done in 5.0 for a year. |
Right now, we don't have any open issues or API proposals related to If we ever have to fix bugs in the Windows-specific APIs, the actual source code is in |
Thanks Carlos, that helps in the decision making process. Ideally we would not resort to any of these hacks but make the net5.0 asset buildable. I don't know what that would involve (API shifting?). @ericstj and I talked about this briefly. |
What bug fix would we do? I think this package only ships a reference assembly and a full facade. |
I didn't know that, great. Sounds to me that removing the package should be considered. |
What does it mean to remove the package? What are the consequences? If we do that, and someone wants to invoke |
We are about removing the infrastructure to produce a package for System.IO.Pipes.AccessControl in this repo's master branch, not removing the package from nuget.org. |
Tagging subscribers to this area: @safern, @ViktorHofer Issue DetailsWe bought back this package here #38177 to expose some apis. Currently to unblock #44373 we harvested the 5.0 and added 6.0 tfm in the package.
cc @ViktorHofer @ericstj @safern
|
@ViktorHofer I believe this can be closed as it is covered by: #47530 ? |
We bought back this package here #38177 to expose some apis.
This package has a dependency on the implementation assembly on System.IO.Pipes which is part of shared framework.
Currently to unblock #44373 we harvested the 5.0 and added 6.0 tfm in the package.
Some other options here are
cc @ViktorHofer @ericstj @safern
The text was updated successfully, but these errors were encountered: