Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API documentation debt - System.Linq #43854

Closed
Tracked by #43849
carlossanlop opened this issue Oct 26, 2020 · 10 comments
Closed
Tracked by #43849

API documentation debt - System.Linq #43854

carlossanlop opened this issue Oct 26, 2020 · 10 comments
Assignees
Labels
area-System.Linq documentation Documentation bug or enhancement, does not impact product or test code help wanted [up-for-grabs] Good issue for external contributors
Milestone

Comments

@carlossanlop
Copy link
Member

carlossanlop commented Oct 26, 2020

Area owners: @eiriktsarpalis @adamsitnik

The APIs in the list below are missing some or all of their documentation. Please add the missing documentation directly in triple slash comments in source. We will make sure it gets ported to dotnet-api-docs after it's merged.

Make sure to follow the documentation guidelines defined in the dotnet-api-docs wiki:
https://github.com/dotnet/dotnet-api-docs/wiki

Also please add me as a PR reviewer.

Community contributions are welcome.

System.Linq
DocId Summary Parameters TypeParameters ReturnValue
M:System.Linq.ImmutableArrayExtensions.Aggregate``3(System.Collections.Immutable.ImmutableArray{``2},``0,System.Func{``0,``2,``0},System.Func{``0,``1}) Present Missing Present Present
M:System.Linq.ImmutableArrayExtensions.Single``1(System.Collections.Immutable.ImmutableArray{``0},System.Func{``0,System.Boolean}) Present Missing Present Present
M:System.Linq.ImmutableArrayExtensions.ToArray``1(System.Collections.Immutable.ImmutableArray{``0}) Present Missing Present Present
@carlossanlop carlossanlop added the documentation Documentation bug or enhancement, does not impact product or test code label Oct 26, 2020
@carlossanlop carlossanlop added this to the 6.0.0 milestone Oct 26, 2020
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added area-System.Collections untriaged New issue has not been triaged by the area owner labels Oct 26, 2020
@ghost
Copy link

ghost commented Oct 26, 2020

Tagging subscribers to this area: @eiriktsarpalis, @jeffhandley
See info in area-owners.md if you want to be subscribed.

@ghost
Copy link

ghost commented Oct 26, 2020

Tagging subscribers to this area: @eiriktsarpalis, @jeffhandley
See info in area-owners.md if you want to be subscribed.

@carlossanlop carlossanlop added the help wanted [up-for-grabs] Good issue for external contributors label Oct 26, 2020
@himanshu8088
Copy link
Contributor

Hey @carlossanlop,

I can pick this up. Please let me know if interested in assigning this to me.
As you mentioned in the description, it seems param is not documented in the following source code, please confirm if this one you are referring to -
https://github.com/dotnet/runtime/blob/master/src/libraries/System.Collections.Immutable/src/System/Linq/ImmutableArrayExtensions.cs

@carlossanlop carlossanlop removed the untriaged New issue has not been triaged by the area owner label Oct 27, 2020
@carlossanlop
Copy link
Member Author

carlossanlop commented Oct 27, 2020

Thank you, @himanshu8088 for offering your help! I assigned this issue to you.

Correct, there are 3 methods in the ImmutableArrayExtensions with one or more missing parameters: Aggregate, Single and ToArray.

The table does not keep in mind any missing exceptions, so if you find any, please add them.

Don't forget to read the documentation guidelines wiki to understand the proper language to use with parameters (and exceptions if you realize any have to be added).

Let me or the area owners know if you have any questions, we will be happy to help.

@himanshu8088
Copy link
Contributor

himanshu8088 commented Oct 30, 2020

Thanks @carlossanlop , I will add fix as per doc guidelines.

@adamsitnik
Copy link
Member

@himanshu8088 please let us know if you need any help

@himanshu8088
Copy link
Contributor

@himanshu8088 please let us know if you need any help

thanks @adamsitnik will let you know if required, I just gave a look over the documentation guidelines and it looks simpler and doable, will start with the code changes in free time.

@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Dec 13, 2020
@jeffhandley
Copy link
Member

@himanshu8088 FYI -- I'm adding @eiriktsarpalis and myself to the assignees for the purpose of seeing this on our team's project board.

@eiriktsarpalis
Copy link
Member

cc @layomia

@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Mar 28, 2021
@eiriktsarpalis
Copy link
Member

Issue was addressed by #51845.

@ghost ghost locked as resolved and limited conversation to collaborators Sep 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Linq documentation Documentation bug or enhancement, does not impact product or test code help wanted [up-for-grabs] Good issue for external contributors
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants