Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm] Add flag to remove non-blittable marshaling functionality from the runtime #43691

Closed
CoffeeFlux opened this issue Oct 21, 2020 · 6 comments
Assignees
Labels
arch-wasm WebAssembly architecture area-VM-meta-mono size-reduction Issues impacting final app size primary for size sensitive workloads
Milestone

Comments

@CoffeeFlux
Copy link
Contributor

Most of this is not needed on wasm and takes up quite a bit of space: for a low-end ballpark: mono_marshal_* is around 15K and emit_* (mostly marshalling) is around 30K. We will need a new flag specifically for this.

We can also push people to use source generators, see #43060

@CoffeeFlux CoffeeFlux added arch-wasm WebAssembly architecture area-VM-meta-mono labels Oct 21, 2020
@CoffeeFlux CoffeeFlux added this to the 6.0.0 milestone Oct 21, 2020
@ghost
Copy link

ghost commented Oct 21, 2020

Tagging subscribers to this area: @CoffeeFlux
See info in area-owners.md if you want to be subscribed.

@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Oct 21, 2020
@CoffeeFlux CoffeeFlux removed the untriaged New issue has not been triaged by the area owner label Oct 21, 2020
@CoffeeFlux CoffeeFlux self-assigned this Nov 11, 2020
@marek-safar marek-safar added the size-reduction Issues impacting final app size primary for size sensitive workloads label Dec 9, 2020
@CoffeeFlux
Copy link
Contributor Author

This was initially added a while back with #46444

There is more work to be done here, since there is more code we can get behind the flag, but the core functionality exists. The remaining bit is lower priority since it's not useful until the Interop team's work on the PInvoke generation is completed.

@SamMonoRT SamMonoRT modified the milestones: 6.0.0, 7.0.0 Jun 21, 2021
@SamMonoRT SamMonoRT assigned SamMonoRT and unassigned CoffeeFlux Jun 21, 2021
@SamMonoRT
Copy link
Member

Remaining low priority work can be tackled in 7.0.0

@lambdageek
Copy link
Member

This is related to #61685, although I think we're aiming for a less #ifdef-y apprach now using mono runtime components instead

@ilonatommy
Copy link
Member

@SamMonoRT, how is it progressing?

@naricc
Copy link
Contributor

naricc commented Aug 1, 2022

This is actualy a duplicate of: #61685, which spells out more details.

@naricc naricc closed this as completed Aug 1, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Aug 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-VM-meta-mono size-reduction Issues impacting final app size primary for size sensitive workloads
Projects
None yet
Development

No branches or pull requests

7 participants